ix(4): Report RX errors as sum of all RX error counters
ClosedPublic
Actions

Authored by piotr.pietruszewski_intel.com on Nov 12 2020, 2:09 PM.

Details

Reviewers

erj
gowtham.kumar.ks_intel.com

Group Reviewers

Intel Networking

Commits

rG5574b12aac2b: ix(4): Report RX errors as sum of all RX error counters
rGadc22165c088: ix(4): Report RX errors as sum of all RX error counters
rG8fa11f892256: ix(4): Report RX errors as sum of all RX error counters
rGafb1aa4e6df2: ix(4): Report RX errors as sum of all RX error counters

Summary

HW keeps track of RX errors using several counters, each for
specific type of errors. Report RX errors to OS as sum
of all those counters: CRC errors, illegal bytes, checksum,
length, undersize, fragment, oversize and jabber errors.

Also, add new "rx_errs" sysctl in the dev.ix.N.mac_stats tree. This is
to provide an another way to display the sum of RX errors.

Signed-off-by: Piotr Pietruszewski <piotr.pietruszewski@intel.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

piotr.pietruszewski_intel.com created this revision.Nov 12 2020, 2:09 PM

Herald added a subscriber: ae. · View Herald TranscriptNov 12 2020, 2:09 PM

piotr.pietruszewski_intel.com requested review of this revision.Nov 12 2020, 2:09 PM

Harbormaster completed remote builds in B34758: Diff 79467.Nov 12 2020, 2:09 PM

piotr.pietruszewski_intel.com added a reviewer: Intel Networking.Nov 12 2020, 2:13 PM

erj accepted this revision as: erj.Nov 20 2020, 12:36 AM

gowtham.kumar.ks_intel.com accepted this revision.Nov 30 2020, 8:50 AM

erj accepted this revision.Mar 3 2021, 1:26 AM

This revision is now accepted and ready to land.Mar 3 2021, 1:26 AM

Closed by commit rGafb1aa4e6df2: ix(4): Report RX errors as sum of all RX error counters (authored by piotr.pietruszewski_intel.com, committed by erj). · Explain WhyMar 3 2021, 1:31 AM

This revision was automatically updated to reflect the committed changes.

erj added a commit: rGafb1aa4e6df2: ix(4): Report RX errors as sum of all RX error counters.

erj added a commit: rG8fa11f892256: ix(4): Report RX errors as sum of all RX error counters.Mar 5 2021, 1:23 AM

erj added a commit: rGadc22165c088: ix(4): Report RX errors as sum of all RX error counters.Mar 11 2021, 1:14 AM

erj added a commit: rG5574b12aac2b: ix(4): Report RX errors as sum of all RX error counters.Sep 20 2021, 11:25 PM

Hi, Piotr.

Can you take a look at the errata for 82599 that does report checksum error when card receives IPv4 UDP packets with zero checksum?
I found several discussion (on Opensense and FreeBSD forums) about this problem that appeared visible after this commit. Also, I found this PR. In our case we see noticeable RX errors on machines that handle SNMP traps.

Herald added a subscriber: imp. · View Herald TranscriptAug 22 2022, 12:02 PM

zlei added a subscriber: zlei.Oct 18 2022, 1:27 AM