Page MenuHomeFreeBSD

mcast: fix leaked igmp packets on multicast cleanup
ClosedPublic

Authored by kp on Dec 13 2023, 1:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 16, 12:12 AM
Unknown Object (File)
Mon, Sep 15, 11:14 PM
Unknown Object (File)
Mon, Sep 15, 10:25 PM
Unknown Object (File)
Sun, Sep 14, 12:53 AM
Unknown Object (File)
Sep 13 2025, 9:11 PM
Unknown Object (File)
Sep 13 2025, 6:42 AM
Unknown Object (File)
Sep 11 2025, 12:30 PM
Unknown Object (File)
Sep 11 2025, 6:09 AM

Details

Summary

When we release a multicast address (e.g. on interface shutdown) we may
still have packets queued in inm_scq. We have to free those, or we'll
leak memory.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Isn't IPv6 part affected too?

Move mbufq_drain() to the same place as in the IPv6 code.

In D43033#981649, @ae wrote:

Isn't IPv6 part affected too?

So that's an interesting point. It turns out that it's not, because in in6m_purge() we do call mbufq_drain(&inm->in6m_scq);.
I've moved my change to match what we do in IPv6.

This revision is now accepted and ready to land.Dec 14 2023, 5:29 PM