Page MenuHomeFreeBSD

mcast: fix leaked igmp packets on multicast cleanup
ClosedPublic

Authored by kp on Dec 13 2023, 1:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 8, 8:29 AM
Unknown Object (File)
Mon, Aug 26, 3:59 PM
Unknown Object (File)
Aug 6 2024, 4:07 PM
Unknown Object (File)
Aug 5 2024, 10:02 PM
Unknown Object (File)
Aug 5 2024, 4:06 PM
Unknown Object (File)
Aug 5 2024, 4:06 PM
Unknown Object (File)
Aug 5 2024, 4:06 PM
Unknown Object (File)
Aug 5 2024, 3:58 PM

Details

Summary

When we release a multicast address (e.g. on interface shutdown) we may
still have packets queued in inm_scq. We have to free those, or we'll
leak memory.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Isn't IPv6 part affected too?

Move mbufq_drain() to the same place as in the IPv6 code.

In D43033#981649, @ae wrote:

Isn't IPv6 part affected too?

So that's an interesting point. It turns out that it's not, because in in6m_purge() we do call mbufq_drain(&inm->in6m_scq);.
I've moved my change to match what we do in IPv6.

This revision is now accepted and ready to land.Dec 14 2023, 5:29 PM