Revert "mcast: fix memory leak in imf_purge()"
ClosedPublic
Actions

Authored by kp on Dec 13 2023, 1:01 PM.

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rGc196e43243b8: Revert "mcast: fix memory leak in imf_purge()"

Summary

This reverts commit fa03d37432caf17d56a931a9e6f5d9b06f102c5b.

This commit caused us to not send IGMP leave messages if the inpcb went
away. In other words: we freed pending packets whenever the socket
closed rather than when the interface (or address) goes away.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Dec 13 2023, 1:01 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptDec 13 2023, 1:01 PM

kp requested review of this revision.Dec 13 2023, 1:01 PM

kp added a parent revision: D43031: ip_mroute: allow MRT_DEL_MFC even if there are pending upcalls.

kp added a child revision: D43033: mcast: fix leaked igmp packets on multicast cleanup.

Harbormaster completed remote builds in B54914: Diff 131326.Dec 13 2023, 1:02 PM

glebius accepted this revision as: glebius.Dec 14 2023, 5:29 PM

This revision is now accepted and ready to land.Dec 14 2023, 5:29 PM

Closed by commit rGc196e43243b8: Revert "mcast: fix memory leak in imf_purge()" (authored by kp). · Explain WhyDec 14 2023, 10:00 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGc196e43243b8: Revert "mcast: fix memory leak in imf_purge()".

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_mcast.c

2 lines

Diff 131457

View Options

Revert "mcast: fix memory leak in imf_purge()"ClosedPublicActions