Page MenuHomeFreeBSD

Add more buffers for ndp in rtsock mode
ClosedPublic

Authored by lytboris_gmail.com on Feb 18 2024, 9:00 AM.
Tags
None
Referenced Files
F159472879: D43956.diff
Sun, Jun 14, 2:49 PM
Unknown Object (File)
Tue, Jun 9, 12:11 PM
Unknown Object (File)
Mon, Jun 8, 12:36 AM
Unknown Object (File)
Sun, Jun 7, 4:37 PM
Unknown Object (File)
Thu, Jun 4, 6:23 PM
Unknown Object (File)
Tue, Jun 2, 12:10 AM
Unknown Object (File)
Mon, May 25, 7:32 AM
Unknown Object (File)
Sun, May 17, 5:04 AM
Subscribers

Details

Summary

On a router with ~10k+ connected devices ndp -an fails with ENOMEM because of some additional NDP records were added between sysctl() buffer size estimate and data fetch calls:

> ndp -an 
ndp: sysctl(PF_ROUTE, NET_RT_FLAGS): Cannot allocate memory

This patch allocates more space based on size estimate: 1/64 (~2%) of additional space, but not less that 4 m_rtmsg structures.

Test Plan

Run

while true; do ndp -an >/dev/null; done

on a router.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2024, 7:54 AM
This revision was automatically updated to reflect the committed changes.