Page MenuHomeFreeBSD

Add more buffers for ndp in rtsock mode
ClosedPublic

Authored by lytboris_gmail.com on Feb 18 2024, 9:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 1:34 AM
Unknown Object (File)
Fri, Oct 10, 7:25 PM
Unknown Object (File)
Fri, Oct 10, 7:25 PM
Unknown Object (File)
Fri, Oct 10, 7:25 PM
Unknown Object (File)
Fri, Oct 10, 2:14 PM
Unknown Object (File)
Thu, Oct 9, 3:05 PM
Unknown Object (File)
Thu, Oct 9, 9:54 AM
Unknown Object (File)
Thu, Sep 25, 2:47 AM
Subscribers

Details

Summary

On a router with ~10k+ connected devices ndp -an fails with ENOMEM because of some additional NDP records were added between sysctl() buffer size estimate and data fetch calls:

> ndp -an 
ndp: sysctl(PF_ROUTE, NET_RT_FLAGS): Cannot allocate memory

This patch allocates more space based on size estimate: 1/64 (~2%) of additional space, but not less that 4 m_rtmsg structures.

Test Plan

Run

while true; do ndp -an >/dev/null; done

on a router.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2024, 7:54 AM
This revision was automatically updated to reflect the committed changes.