Page MenuHomeFreeBSD

route: fix rtentry double free
ClosedPublic

Authored by kp on Jun 3 2025, 12:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 9:03 PM
Unknown Object (File)
Fri, Oct 3, 7:27 AM
Unknown Object (File)
Fri, Oct 3, 12:13 AM
Unknown Object (File)
Wed, Oct 1, 10:04 PM
Unknown Object (File)
Tue, Sep 30, 8:45 AM
Unknown Object (File)
Fri, Sep 26, 2:20 AM
Unknown Object (File)
Sep 8 2025, 4:30 PM
Unknown Object (File)
Sep 8 2025, 9:21 AM

Details

Summary

add_route_flags() frees the rtentry on error when called with the RTM_F_CREATE
flag. Don't free the rtentry a second time.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.Jun 3 2025, 12:49 PM
sys/net/route/route_ctl.c
676

Then isn't this access to freed rt_new?

sys/net/route/route_ctl.c
676

Good catch, I missed that one.
I think we can get away with using 'rt' here instead of 'rt_new', because rt_new should be a copy of rt.

Remove one more use of rt_new

This revision is now accepted and ready to land.Jun 5 2025, 7:36 AM
This revision was automatically updated to reflect the committed changes.