Differential D50658

pf: use 'struct ah' for the AH extension header rather than 'struct ip6_ext'
ClosedPublic
Actions

Authored by kp on Jun 3 2025, 12:48 PM.

Details

Reviewers

None

Group Reviewers

pfsense

Commits

rG3be4d54ecd11: pf: use 'struct ah' for the AH extension header rather than 'struct ip6_ext'

Summary

This fixes the build for NOINET6 kernels, but also more accurately reflects what
we're doing. The first two fields are the same, so the only functional change is
that we require slightly more data in the first fragment now.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Jun 3 2025, 12:48 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptJun 3 2025, 12:48 PM

kp requested review of this revision.Jun 3 2025, 12:48 PM

Harbormaster completed remote builds in B64607: Diff 156464.Jun 3 2025, 12:48 PM

kp added a parent revision: D50657: pf: align IPv4 and IPv6 AH header handling.Jun 3 2025, 12:48 PM

kp added a child revision: D50659: pf: limit how many headers we look at.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 6 2025, 11:17 AM

Closed by commit rG3be4d54ecd11: pf: use 'struct ah' for the AH extension header rather than 'struct ip6_ext' (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG3be4d54ecd11: pf: use 'struct ah' for the AH extension header rather than 'struct ip6_ext'.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

8 lines

Diff 156611

View Options

pf: use 'struct ah' for the AH extension header rather than 'struct ip6_ext'ClosedPublicActions