Page MenuHomeFreeBSD
Differential D46597

pf: merge pf_scrub_ip() and pf_scrub_ip6()
ClosedPublic
Actions

Authored by kp on Sep 7 2024, 9:37 AM.
Tags
None
Referenced Files
F166220103: D46597.id143093.diff
Wed, Aug 12, 11:10 AM
Unknown Object (File)
Sat, Aug 8, 1:35 PM
Unknown Object (File)
Sat, Aug 8, 12:23 PM
Unknown Object (File)
Fri, Aug 7, 10:47 AM
Unknown Object (File)
Thu, Aug 6, 8:22 AM
Unknown Object (File)
Wed, Jul 29, 9:22 PM
Unknown Object (File)
Sun, Jul 19, 4:06 PM
Unknown Object (File)
Sat, Jul 18, 7:29 AM
View All Files
Subscribers
ae
farrokhi
glebius
imp
melifaro
vegeta_tuxpowered.net
zlei

Details

Reviewers
zlei
Group Reviewers
network
pfsense
Commits
rG4f9e688708f1: pf: merge pf_scrub_ip() and pf_scrub_ip6()
Summary

Merge pf_scrub_ip() and pf_scrub_ip6() into a single function. Call
pf_scrub with the right arugments in the rule case so that match
rules will work as expected.

OK henning@

Obtained from: OpenBSD, claudio <claudio@openbsd.org>, 48c45e6969
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Sep 7 2024, 9:37 AM
Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 3 others. · View Herald TranscriptSep 7 2024, 9:37 AM
kp requested review of this revision.Sep 7 2024, 9:37 AM
Harbormaster completed remote builds in B59385: Diff 143093.Sep 7 2024, 9:37 AM
kp added a parent revision: D46596: pf: do not pass af to PFLOG_PACKET.Sep 7 2024, 9:37 AM
kp added a child revision: D46598: pf: remove unused argument 'h' from various function.
zlei accepted this revision as: zlei.Sep 14 2024, 8:32 AM
zlei added a subscriber: zlei.
zlei added inline comments.
sys/netpfil/pf/pf_norm.c
2281–2283

Emm, I'd personally prefer big switch case blocks, rather than test pd->af everywhere. But no objection since it is from upstream.

This revision is now accepted and ready to land.Sep 14 2024, 8:32 AM
Closed by commit rG4f9e688708f1: pf: merge pf_scrub_ip() and pf_scrub_ip6() (authored by kp). · Explain WhySep 25 2024, 12:35 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG4f9e688708f1: pf: merge pf_scrub_ip() and pf_scrub_ip6().

Revision Contents
Changeset List

PathSize
sys/
net/
9 lines
netpfil/
pf/
4 lines
60 lines

Diff 143704

View Options

sys/net/pfvar.h

Loading...
View Options

sys/netpfil/pf/pf.c

Loading...
View Options

sys/netpfil/pf/pf_norm.c

Loading...