Page MenuHomeFreeBSD

pf: merge pf_scrub_ip() and pf_scrub_ip6()
ClosedPublic

Authored by kp on Sep 7 2024, 9:37 AM.
Tags
None
Referenced Files
F99207279: D46597.diff
Mon, Oct 7, 8:10 AM
Unknown Object (File)
Wed, Sep 25, 12:35 PM
Unknown Object (File)
Sat, Sep 21, 8:55 PM
Unknown Object (File)
Sat, Sep 21, 4:25 PM
Unknown Object (File)
Fri, Sep 20, 10:52 AM
Unknown Object (File)
Thu, Sep 19, 9:16 PM
Unknown Object (File)
Sat, Sep 14, 4:21 PM
Unknown Object (File)
Wed, Sep 11, 9:56 PM

Details

Summary

Merge pf_scrub_ip() and pf_scrub_ip6() into a single function. Call
pf_scrub with the right arugments in the rule case so that match
rules will work as expected.

OK henning@

Obtained from: OpenBSD, claudio <claudio@openbsd.org>, 48c45e6969
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.Sep 7 2024, 9:37 AM
zlei added a subscriber: zlei.
zlei added inline comments.
sys/netpfil/pf/pf_norm.c
2281–2283

Emm, I'd personally prefer big switch case blocks, rather than test pd->af everywhere. But no objection since it is from upstream.

This revision is now accepted and ready to land.Sat, Sep 14, 8:32 AM
This revision was automatically updated to reflect the committed changes.