pf: remove redundant checks
ClosedPublic
Actions

Authored by kp on Sep 7 2024, 9:36 AM.

Tags

None

Referenced Files

	F146324795: D46591.id143488.diff
	Sun, Mar 1, 6:28 PM

	F146323734: D46591.id143488.diff
	Sun, Mar 1, 6:16 PM

	Unknown Object (File)
	Mon, Feb 16, 10:04 AM

	Unknown Object (File)
	Sun, Feb 8, 5:12 PM

	Unknown Object (File)
	Jan 14 2026, 1:27 PM

	Unknown Object (File)
	Dec 12 2025, 3:02 PM

	Unknown Object (File)
	Nov 22 2025, 11:48 PM

	Unknown Object (File)
	Nov 17 2025, 2:35 AM

Subscribers

vegeta_tuxpowered.net

zlei

Details

Reviewers

zlei

Group Reviewers

network
pfsense

Commits

rG5130165be136: pf: remove redundant checks

Summary

pf_test() and pf_test6() drop IPv4-ICMP6 and IPv6-ICMP packets. Do
not do the same check in pf_test_rule() again.
ok henning

Obtained from: OpenBSD, bluhm <bluhm@openbsd.org>, de5c2bfb74
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Sep 7 2024, 9:36 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSep 7 2024, 9:36 AM

Harbormaster completed remote builds in B59379: Diff 143087.Sep 7 2024, 9:36 AM

kp requested review of this revision.Sep 7 2024, 9:36 AM

kp added a parent revision: D46590: pf: factor out rule counter update code.

kp added a child revision: D46592: pf: handle ACK prioritization for v6.

Looks good to me.

This revision is now accepted and ready to land.Sep 14 2024, 8:06 AM

Closed by commit rG5130165be136: pf: remove redundant checks (authored by kp). · Explain WhySep 19 2024, 8:22 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG5130165be136: pf: remove redundant checks.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

6 lines

Diff 143488

View Options

pf: remove redundant checksClosedPublicActions