Page MenuHomeFreeBSD
Differential D46582

pfctl: lex <=, >=, and != into a single token
ClosedPublic
Actions

Authored by kp on Sep 7 2024, 9:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 1:47 AM
Unknown Object (File)
Sep 17 2025, 9:26 PM
Unknown Object (File)
Sep 8 2025, 2:41 PM
Unknown Object (File)
Sep 4 2025, 4:30 PM
Unknown Object (File)
Aug 30 2025, 5:23 PM
Unknown Object (File)
Aug 14 2025, 11:20 PM
Unknown Object (File)
Aug 6 2025, 5:54 AM
Unknown Object (File)
Aug 6 2025, 5:54 AM
View All 80 Files
Subscribers
imp
zlei

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rG80eb861dc2a7: pfctl: lex <=, >=, and != into a single token
Summary

lex <=, >=, and != into a single token for correctness and to reduce the
lookahead in the parser
ok henning otto

Obtained from: OpenBSD, deraadt <deraadt@openbsd.org>, e6e3ecf338
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Sep 7 2024, 9:34 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 7 2024, 9:34 AM
kp requested review of this revision.Sep 7 2024, 9:34 AM
Harbormaster completed remote builds in B59370: Diff 143078.Sep 7 2024, 9:34 AM
kp added a parent revision: D46581: pf tests: ensure we correctly optimize { any, 192.0.2.3 }.Sep 7 2024, 9:35 AM
kp added a child revision: D46583: pf: fix potential memory leaks in pf_create_state().
zlei added a subscriber: zlei.Sep 14 2024, 7:50 AM

I like this change, from my limited parser knowledge :)

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2024, 1:06 PM
Closed by commit rG80eb861dc2a7: pfctl: lex <=, >=, and != into a single token (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG80eb861dc2a7: pfctl: lex <=, >=, and != into a single token.

Revision Contents
Changeset List

PathSize
sbin/
pfctl/
20 lines

Diff 143390

View Options

sbin/pfctl/parse.y

Loading...