Page MenuHomeFreeBSD
Differential D46590

pf: factor out rule counter update code
ClosedPublic
Actions

Authored by kp on Sat, Sep 7, 9:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 20, 12:12 AM
Unknown Object (File)
Mon, Sep 16, 3:15 PM
Unknown Object (File)
Sun, Sep 15, 5:57 PM
Unknown Object (File)
Wed, Sep 11, 10:56 PM
Unknown Object (File)
Wed, Sep 11, 8:24 AM
Unknown Object (File)
Wed, Sep 11, 5:51 AM
Unknown Object (File)
Sat, Sep 7, 7:17 PM
Unknown Object (File)
Sat, Sep 7, 5:26 PM
View All 12 Files
Subscribers
farrokhi
glebius
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rG1fd02d1e1522: pf: factor out rule counter update code
Summary

Break out rule counter update code into a separate function, makes the
behaviour consistent between IPv4 and IPv6.

From martin.pelikan@gmail.com

Obtained from: OpenBSD, mcbride <mcbride@openbsd.org>, ce38da5678
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Sat, Sep 7, 9:36 AM
Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSat, Sep 7, 9:36 AM
kp requested review of this revision.Sat, Sep 7, 9:36 AM
Harbormaster completed remote builds in B59378: Diff 143086.Sat, Sep 7, 9:36 AM
kp added a parent revision: D46589: pf tests: test the new log(matches) feature.Sat, Sep 7, 9:36 AM
kp added a child revision: D46591: pf: remove redundant checks.
vegeta_tuxpowered.net added inline comments.Mon, Sep 9, 6:05 PM
sys/netpfil/pf/pf.c
8859

struct pf_pdesc *pd already contains dir.

kp updated this revision to Diff 143178.Tue, Sep 10, 8:52 AM

Remove 'dir' argument.

Harbormaster completed remote builds in B59417: Diff 143178.Tue, Sep 10, 8:52 AM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Sep 19, 8:22 PM
Closed by commit rG1fd02d1e1522: pf: factor out rule counter update code (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG1fd02d1e1522: pf: factor out rule counter update code.

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
213 lines

Diff 143487

View Options

sys/netpfil/pf/pf.c

Loading...