Paths

Table of Contentst

pf tests: ensure we correctly optimize { any, 192.0.2.3 }
ClosedPublic
Actions

Authored by kp on Sep 7 2024, 9:34 AM.

Tags

None

Referenced Files

	F166278127: D46581.id143388.diff
	Wed, Aug 12, 4:19 PM

	F166278053: D46581.id143077.diff
	Wed, Aug 12, 4:18 PM

	F166274687: D46581.id143388.diff
	Wed, Aug 12, 4:00 PM

	Unknown Object (File)
	Mon, Aug 10, 7:24 PM

	Unknown Object (File)
	Sat, Aug 8, 6:42 PM

	Unknown Object (File)
	Mon, Aug 3, 5:34 AM

	Unknown Object (File)
	Wed, Jul 29, 8:10 PM

	Unknown Object (File)
	Sun, Jul 26, 12:45 AM

Subscribers

vegeta_tuxpowered.net

zlei

Details

Reviewers

zlei

Group Reviewers

network
pfsense

Commits

rG357c95ea4663: pf tests: ensure we correctly optimize { any, 192.0.2.3 }

Summary

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Sep 7 2024, 9:34 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSep 7 2024, 9:34 AM

kp requested review of this revision.Sep 7 2024, 9:34 AM

Harbormaster completed remote builds in B59369: Diff 143077.Sep 7 2024, 9:34 AM

kp added a parent revision: D46580: pfctl: fix incorrect optimization.Sep 7 2024, 9:34 AM

kp added a child revision: D46582: pfctl: lex <=, >=, and != into a single token.

Looks good to me.

tests/sys/netpfil/pf/pass_block.sh
379	Is `know` really `known` ?

This revision is now accepted and ready to land.Sep 14 2024, 7:48 AM

kp added inline comments.Sep 16 2024, 10:13 AM

tests/sys/netpfil/pf/pass_block.sh
379	Yes, I'll fix that.

Closed by commit rG357c95ea4663: pf tests: ensure we correctly optimize { any, 192.0.2.3 } (authored by kp). · Explain WhySep 16 2024, 1:06 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG357c95ea4663: pf tests: ensure we correctly optimize { any, 192.0.2.3 }.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

pf/

pass_block.sh

36 lines

Diff 143388

View Options

tests/sys/netpfil/pf/pass_block.sh

pf tests: ensure we correctly optimize { any, 192.0.2.3 }ClosedPublicActions