Page MenuHomeFreeBSD
Differential D46576

pf: use AF_INET6 when comparing IPv6 addresses
ClosedPublic
Actions

Authored by kp on Sep 7 2024, 9:33 AM.
Tags
None
Referenced Files
F165246251: D46576.diff
Fri, Aug 7, 3:43 AM
Unknown Object (File)
Thu, Aug 6, 7:25 AM
Unknown Object (File)
Wed, Aug 5, 4:35 AM
Unknown Object (File)
Tue, Jul 21, 10:11 AM
Unknown Object (File)
Mon, Jul 20, 9:20 AM
Unknown Object (File)
Sun, Jul 19, 5:53 PM
Unknown Object (File)
Jul 2 2026, 4:35 AM
Unknown Object (File)
Jun 19 2026, 10:33 PM
View All Files
Subscribers
farrokhi
glebius
imp
melifaro
vegeta_tuxpowered.net
zlei

Details

Reviewers
zlei
Group Reviewers
network
pfsense
Commits
rG5dd89e6b6777: pf: use AF_INET6 when comparing IPv6 addresses
rGc5a9d5ff0c0c: pf: use AF_INET6 when comparing IPv6 addresses
rG50ecaf1bd46a: pf: use AF_INET6 when comparing IPv6 addresses
Summary

MFC after: 1 week
Obtained from: OpenBSD, henning <henning@openbsd.org>, cf7c0bf78a
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Sep 7 2024, 9:33 AM
Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSep 7 2024, 9:33 AM
kp requested review of this revision.Sep 7 2024, 9:33 AM
kp added a parent revision: D46575: pf: always drop ICMPv6 in IPv4 datagrams.
Harbormaster completed remote builds in B59364: Diff 143072.Sep 7 2024, 9:34 AM
kp added a child revision: D46577: pf: allow filtering on the receive interface.Sep 7 2024, 9:34 AM
zlei accepted this revision as: zlei.Sep 14 2024, 7:28 AM
zlei added a subscriber: zlei.

Looks good to me.

sys/netpfil/pf/pf.c
7651

I guess there're bugs before this change ;)

This revision is now accepted and ready to land.Sep 14 2024, 7:28 AM
kp added a comment.Sep 16 2024, 9:02 AM

I've never seen reports of it, but yeah, I'd expect there might be.

Closed by commit rG50ecaf1bd46a: pf: use AF_INET6 when comparing IPv6 addresses (authored by kp). · Explain WhySep 16 2024, 1:05 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG50ecaf1bd46a: pf: use AF_INET6 when comparing IPv6 addresses.
kp added a commit: rGc5a9d5ff0c0c: pf: use AF_INET6 when comparing IPv6 addresses.Sep 23 2024, 9:33 PM
kp added a commit: rG5dd89e6b6777: pf: use AF_INET6 when comparing IPv6 addresses.

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
4 lines

Diff 143384

View Options

sys/netpfil/pf/pf.c

Loading...