pf: fix potential memory leaks in pf_create_state()
Needs ReviewPublic
Actions

Authored by kp on Sat, Sep 7, 9:35 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 11, 10:43 PM

	Unknown Object (File)
	Wed, Sep 11, 10:43 PM

	Unknown Object (File)
	Wed, Sep 11, 6:29 PM

	Unknown Object (File)
	Wed, Sep 11, 5:48 PM

	Unknown Object (File)
	Sun, Sep 8, 4:38 AM

	Unknown Object (File)
	Sat, Sep 7, 8:03 PM

	Unknown Object (File)
	Sat, Sep 7, 6:55 PM

	Unknown Object (File)
	Sat, Sep 7, 6:33 PM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

None

Group Reviewers

network
pfsense

Summary

If we fail to init TCP (or SCTP) initialization we have to remember to free
state keys as well. They will not be freed for us when we free the state until
we've inserted the state (i.e. pf_insert_state()).

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59371
Build 56258: arc lint + arc unit

Event Timeline

kp created this revision.Sat, Sep 7, 9:35 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSat, Sep 7, 9:35 AM

kp requested review of this revision.Sat, Sep 7, 9:35 AM

Harbormaster completed remote builds in B59371: Diff 143079.Sat, Sep 7, 9:35 AM

kp added a parent revision: D46582: pfctl: lex <=, >=, and != into a single token.Sat, Sep 7, 9:35 AM

kp added a child revision: D46584: pfctl: improve bitmask printing.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

8 lines

Diff 143079

View Options

pf: fix potential memory leaks in pf_create_state()Needs ReviewPublicActions