Prior to 948e8413 the NAT log was implicitly
using r->action, but it was changed to an explicit
PF_PASS. Restore the correct behaviour by
explicitly passing nr->action.
Add a test for it while here.
Differential D47777
pf: NAT rule logs its own NAT action, not PF_PASS franco_opnsense.org on Wed, Nov 27, 9:28 AM. Authored by Tags None Referenced Files
Details
Diff Detail
Event TimelineComment Actions D47658 is on hold as I struggle to understand why the code discussed there is not covered by existing tests and how to actually trigger it (it should easily panic after all but the code is never hit). Comment Actions Then please update that review to state that there. As for this one, let's start with the commit message. Try to explain both the problem and then justify chosen solution. 'fix regression' does not enlighten. Comment Actions I changed the summary. I'll gladly update the other review and I also appreciate a response to my last comment there. Comment Actions Feel free to make a different suggestion. I've long been under the impressions explaining one liners is not the scope of a commit message and the tests should make this rather clear as requested in previous discussions. Comment Actions What's the status now? From my point of you I've explained the previous behaviour, the change that caused this to exhibit the wrong behaviour and how it was fixed. I'd like to get to a more productive cooperation based on technical urgency. I don't think tests prevented this from happening and I don't think the issue gets any better discussing commit messages. |