pf: factor out rule counter update code
ClosedPublic
Actions

Authored by kp on Sep 7 2024, 9:36 AM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG1fd02d1e1522: pf: factor out rule counter update code

Summary

Break out rule counter update code into a separate function, makes the
behaviour consistent between IPv4 and IPv6.

From martin.pelikan@gmail.com

Obtained from: OpenBSD, mcbride <mcbride@openbsd.org>, ce38da5678
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59417
Build 56304: arc lint + arc unit

Event Timeline

kp created this revision.Sep 7 2024, 9:36 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSep 7 2024, 9:36 AM

kp requested review of this revision.Sep 7 2024, 9:36 AM

Harbormaster completed remote builds in B59378: Diff 143086.Sep 7 2024, 9:36 AM

kp added a parent revision: D46589: pf tests: test the new log(matches) feature.Sep 7 2024, 9:36 AM

kp added a child revision: D46591: pf: remove redundant checks.

vegeta_tuxpowered.net added inline comments.Sep 9 2024, 6:05 PM

sys/netpfil/pf/pf.c
8853	`struct pf_pdesc *pd` already contains `dir`.

Remove 'dir' argument.

Harbormaster completed remote builds in B59417: Diff 143178.Sep 10 2024, 8:52 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 19 2024, 8:22 PM

Closed by commit rG1fd02d1e1522: pf: factor out rule counter update code (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG1fd02d1e1522: pf: factor out rule counter update code.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

213 lines

Diff 143178

View Options

pf: factor out rule counter update codeClosedPublicActions