Page MenuHomeFreeBSD
Differential D46597

pf: merge pf_scrub_ip() and pf_scrub_ip6()
ClosedPublic
Actions

Authored by kp on Sep 7 2024, 9:37 AM.
Tags
None
Referenced Files
F132979329: D46597.diff
Tue, Oct 21, 6:53 PM
Unknown Object (File)
Tue, Oct 21, 12:58 AM
Unknown Object (File)
Fri, Oct 17, 10:01 PM
Unknown Object (File)
Fri, Sep 26, 4:44 PM
Unknown Object (File)
Thu, Sep 25, 2:49 AM
Unknown Object (File)
Wed, Sep 24, 3:07 AM
Unknown Object (File)
Aug 30 2025, 5:28 PM
Unknown Object (File)
Aug 29 2025, 7:42 AM
View All 58 Files
Subscribers
ae
farrokhi
glebius
imp
melifaro
vegeta_tuxpowered.net
zlei

Details

Reviewers
zlei
Group Reviewers
network
pfsense
Commits
rG4f9e688708f1: pf: merge pf_scrub_ip() and pf_scrub_ip6()
Summary

Merge pf_scrub_ip() and pf_scrub_ip6() into a single function. Call
pf_scrub with the right arugments in the rule case so that match
rules will work as expected.

OK henning@

Obtained from: OpenBSD, claudio <claudio@openbsd.org>, 48c45e6969
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59385
Build 56272: arc lint + arc unit

Event Timeline

kp created this revision.Sep 7 2024, 9:37 AM
Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 3 others. · View Herald TranscriptSep 7 2024, 9:37 AM
kp requested review of this revision.Sep 7 2024, 9:37 AM
Harbormaster completed remote builds in B59385: Diff 143093.Sep 7 2024, 9:37 AM
kp added a parent revision: D46596: pf: do not pass af to PFLOG_PACKET.Sep 7 2024, 9:37 AM
kp added a child revision: D46598: pf: remove unused argument 'h' from various function.
zlei accepted this revision as: zlei.Sep 14 2024, 8:32 AM
zlei added a subscriber: zlei.
zlei added inline comments.
sys/netpfil/pf/pf_norm.c
2281

Emm, I'd personally prefer big switch case blocks, rather than test pd->af everywhere. But no objection since it is from upstream.

This revision is now accepted and ready to land.Sep 14 2024, 8:32 AM
Closed by commit rG4f9e688708f1: pf: merge pf_scrub_ip() and pf_scrub_ip6() (authored by kp). · Explain WhySep 25 2024, 12:35 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG4f9e688708f1: pf: merge pf_scrub_ip() and pf_scrub_ip6().

Revision Contents
Changeset List

PathSize
sys/
net/
9 lines
netpfil/
pf/
4 lines
60 lines

Diff 143093

View Options

sys/net/pfvar.h

Loading...
View Options

sys/netpfil/pf/pf.c

Loading...
View Options

sys/netpfil/pf/pf_norm.c

Loading...