pf: remove ip(6) header argument from pf_reassemble(6)()
ClosedPublic
Actions

Authored by kp on Sep 12 2024, 1:14 PM.

Tags

None

Referenced Files

	F110250487: D46652.id143833.diff
	Sat, Feb 15, 6:01 PM

	F110249200: D46652.id143278.diff
	Sat, Feb 15, 5:35 PM

	F110225647: D46652.diff
	Sat, Feb 15, 9:21 AM

	Unknown Object (File)
	Fri, Jan 17, 1:19 PM

	Unknown Object (File)
	Dec 28 2024, 7:58 AM

	Unknown Object (File)
	Nov 28 2024, 12:52 PM

	Unknown Object (File)
	Nov 22 2024, 10:46 PM

	Unknown Object (File)
	Nov 14 2024, 10:16 PM

Subscribers

vegeta_tuxpowered.net

zlei

Details

Reviewers

zlei

Group Reviewers

network
pfsense

Commits

rGf8e994296328: pf: remove ip(6) header argument from pf_reassemble(6)()

Summary

Instead of passing the ip header and mbuf to pf_reassemble(), lookup
the header address in the mbuf.
ok henning@

Obtained from: OpenBSD, bluhm <bluhm@openbsd.org>, 074ee1f915
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Sep 12 2024, 1:14 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSep 12 2024, 1:14 PM

kp requested review of this revision.Sep 12 2024, 1:14 PM

Harbormaster completed remote builds in B59455: Diff 143278.Sep 12 2024, 1:14 PM

Looks good to me. I read this code carefully :)

This revision is now accepted and ready to land.Sep 14 2024, 7:05 AM

Closed by commit rGf8e994296328: pf: remove ip(6) header argument from pf_reassemble(6)() (authored by kp). · Explain WhySep 27 2024, 10:17 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGf8e994296328: pf: remove ip(6) header argument from pf_reassemble(6)().

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_norm.c

14 lines

Diff 143833

View Options

pf: remove ip(6) header argument from pf_reassemble(6)()ClosedPublicActions