Differential D46937

pf: consolidate pf function parameters
ClosedPublic
Actions

Authored by kp on Oct 4 2024, 12:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Feb 14 2025, 12:30 PM

	Unknown Object (File)
	Feb 11 2025, 9:29 PM

	Unknown Object (File)
	Feb 11 2025, 6:19 PM

	Unknown Object (File)
	Feb 10 2025, 12:07 PM

	Unknown Object (File)
	Jan 18 2025, 5:05 AM

	Unknown Object (File)
	Jan 7 2025, 3:28 AM

	Unknown Object (File)
	Dec 8 2024, 11:01 AM

	Unknown Object (File)
	Dec 4 2024, 2:50 AM

View All 19 Files

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG739731b8ca80: pf: consolidate pf function parameters

Summary

Move off and hdrlen into pdesc
and change their type from int to u_int32_t. Do not pass struct
tcphdr *th and sa_family_t af, it is in pd anyway. Do not use af
and pd->af intermixed, the latter makes clear where it comes from.
Do not calculate the packet length again if pd already has it. Use
pd2.off instead of off2.
go go go go don't stop henning@ mpf@

Obtained from: OpenBSD, bluhm <bluhm@openbsd.org>, 110e53770d
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Oct 4 2024, 12:45 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 3 others. · View Herald TranscriptOct 4 2024, 12:45 PM

kp requested review of this revision.Oct 4 2024, 12:45 PM

Harbormaster completed remote builds in B59750: Diff 144239.Oct 4 2024, 12:45 PM

kp added a parent revision: D46936: pf: unify some IPv4/IPv6 code in pf_setup_pdesc().Oct 4 2024, 12:45 PM

kp added a child revision: D46938: pf: convert DIOCGETRULESET to netlink.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 10 2024, 12:38 PM

Closed by commit rG739731b8ca80: pf: consolidate pf function parameters (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG739731b8ca80: pf: consolidate pf function parameters.

Revision Contents
Changeset List

Path

Size

sys/

net/

29 lines

netpfil/

pf/

387 lines

20 lines

39 lines

4 lines

pf_syncookies.c

13 lines

Diff 144587

sys/net/pfvar.h

Loading...

sys/netpfil/pf/pf.c

Loading...

sys/netpfil/pf/pf_lb.c

Loading...

sys/netpfil/pf/pf_norm.c

Loading...

sys/netpfil/pf/pf_osfp.c

Loading...

sys/netpfil/pf/pf_syncookies.c

Loading...