pf: pf_clear_srcnodes() is always called with NULL
ClosedPublic
Actions

Authored by vegeta_tuxpowered.net on Sep 27 2024, 3:56 PM.

Tags

None

Referenced Files

	F139415948: D46819.id143874.diff
	Thu, Dec 11, 8:17 PM

	Unknown Object (File)
	Thu, Nov 27, 8:20 AM

	Unknown Object (File)
	Sat, Nov 15, 11:33 PM

	Unknown Object (File)
	Nov 11 2025, 3:39 PM

	Unknown Object (File)
	Nov 11 2025, 9:13 AM

	Unknown Object (File)
	Nov 11 2025, 7:48 AM

	Unknown Object (File)
	Nov 9 2025, 10:14 PM

	Unknown Object (File)
	Oct 17 2025, 8:18 PM

Subscribers

Details

Reviewers

Commits

rG37881f65eacd: pf: pf_clear_srcnodes() is always called with NULL

Summary

The functions pf_clear_srcnodes() is only used to perform a removal of
all source nodes, never of a given one. Remove the code allowing for
removal of a given source node.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vegeta_tuxpowered.net created this revision.Sep 27 2024, 3:56 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptSep 27 2024, 3:56 PM

vegeta_tuxpowered.net requested review of this revision.Sep 27 2024, 3:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 28 2024, 7:23 PM

Closed by commit rG37881f65eacd: pf: pf_clear_srcnodes() is always called with NULL (authored by vegeta_tuxpowered.net, committed by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG37881f65eacd: pf: pf_clear_srcnodes() is always called with NULL.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_ioctl.c

42 lines

Diff 143874

View Options

pf: pf_clear_srcnodes() is always called with NULLClosedPublicActions