Differential D46774

pf tests: Add max states test
ClosedPublic
Actions

Authored by vegeta_tuxpowered.net on Sep 24 2024, 3:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 26, 7:10 PM

	Unknown Object (File)
	Tue, Nov 26, 2:56 AM

	Unknown Object (File)
	Fri, Nov 22, 7:12 PM

	Unknown Object (File)
	Fri, Nov 22, 1:24 AM

	Unknown Object (File)
	Fri, Nov 22, 1:24 AM

	Unknown Object (File)
	Thu, Nov 21, 3:39 AM

	Unknown Object (File)
	Fri, Nov 15, 10:59 PM

	Unknown Object (File)
	Fri, Nov 15, 10:43 PM

View All 23 Files

Subscribers

Details

Reviewers

Commits

rG67bd1d072190: pf tests: Add max states test

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vegeta_tuxpowered.net created this revision.Sep 24 2024, 3:47 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptSep 24 2024, 3:47 PM

vegeta_tuxpowered.net requested review of this revision.Sep 24 2024, 3:47 PM

vegeta_tuxpowered.net updated this revision to Diff 143674.

kp added inline comments.Sep 25 2024, 12:52 PM

sys/netpfil/pf/max_states.sh
46 ↗	(On Diff #143674)	Do we know why that is, because this feels like you've discovered a bug we should fix before we commit this test.

vegeta_tuxpowered.net added inline comments.Sep 25 2024, 12:57 PM

sys/netpfil/pf/max_states.sh
46 ↗	(On Diff #143674)	I have another patch which fixes the off by 1 error. I will upload it to Phabricator soon. But I want first to have all patches which don't change the current, even buggy, behaviours merged.

kp added inline comments.Sep 25 2024, 1:12 PM

sys/netpfil/pf/max_states.sh
46 ↗	(On Diff #143674)	I'd usually hold the test until after things are fixed, but I don't prefer that enough to make you do extra work. I'll land this this way, it's not as if it's hard to fix the test once the bug is fixed. (As an aside, I may need a bit more time for your next patch. You may have noticed I'm in the process of merging a bunch of openbsd patches and I want to make sure that your work and mine isn't going to conflict there.)

This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2024, 3:27 PM

Closed by commit rG67bd1d072190: pf tests: Add max states test (authored by vegeta_tuxpowered.net, committed by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG67bd1d072190: pf tests: Add max states test.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

pf/

1 line

61 lines

Diff 143720

tests/sys/netpfil/pf/Makefile

Loading...

tests/sys/netpfil/pf/max_states.sh

Loading...