Page MenuHomeFreeBSD

pf tests: Add max states test
ClosedPublic

Authored by vegeta_tuxpowered.net on Sep 24 2024, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 9:25 AM
Unknown Object (File)
Sat, Nov 9, 4:51 PM
Unknown Object (File)
Sat, Nov 9, 4:48 PM
Unknown Object (File)
Sat, Nov 9, 4:48 PM
Unknown Object (File)
Sat, Nov 9, 4:48 PM
Unknown Object (File)
Wed, Nov 6, 11:34 PM
Unknown Object (File)
Wed, Nov 6, 7:51 AM
Unknown Object (File)
Sun, Oct 20, 4:49 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/netpfil/pf/max_states.sh
46 ↗(On Diff #143674)

Do we know why that is, because this feels like you've discovered a bug we should fix before we commit this test.

sys/netpfil/pf/max_states.sh
46 ↗(On Diff #143674)

I have another patch which fixes the off by 1 error. I will upload it to Phabricator soon. But I want first to have all patches which don't change the current, even buggy, behaviours merged.

sys/netpfil/pf/max_states.sh
46 ↗(On Diff #143674)

I'd usually hold the test until after things are fixed, but I don't prefer that enough to make you do extra work.

I'll land this this way, it's not as if it's hard to fix the test once the bug is fixed.

(As an aside, I may need a bit more time for your next patch. You may have noticed I'm in the process of merging a bunch of openbsd patches and I want to make sure that your work and mine isn't going to conflict there.)

This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2024, 3:27 PM
This revision was automatically updated to reflect the committed changes.