Details
Details
- Reviewers
kp - Commits
- rG67bd1d072190: pf tests: Add max states test
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| sys/netpfil/pf/max_states.sh | ||
|---|---|---|
| 46 ↗ | (On Diff #143674) | Do we know why that is, because this feels like you've discovered a bug we should fix before we commit this test. |
| sys/netpfil/pf/max_states.sh | ||
|---|---|---|
| 46 ↗ | (On Diff #143674) | I have another patch which fixes the off by 1 error. I will upload it to Phabricator soon. But I want first to have all patches which don't change the current, even buggy, behaviours merged. |
| sys/netpfil/pf/max_states.sh | ||
|---|---|---|
| 46 ↗ | (On Diff #143674) | I'd usually hold the test until after things are fixed, but I don't prefer that enough to make you do extra work. I'll land this this way, it's not as if it's hard to fix the test once the bug is fixed. (As an aside, I may need a bit more time for your next patch. You may have noticed I'm in the process of merging a bunch of openbsd patches and I want to make sure that your work and mine isn't going to conflict there.) |