rc: add a manual entry for ${name}_setup

[franco_opnsense.org]

Summary

${name}_prepend is suboptimal as it is prepended to the actual
command being run. Therefore the term "commandS to prepend"
is misleading and no clear separation takes place for setup tasks
that may be required like changing a config file permission or
generating a configuration file prior to service start.

The other reason is that {argument}_precmd is a service-side
variable and cannot be repurposed from the user-side.

[pauamma_gundo.com]

English LGTM and the addition of ${name}_setup looks consistent with https://reviews.freebsd.org/D36006 to my untrained eye. I can't say whether the change to ${name}_prepend is correct.

[0mp]

"Commands" is correct because it can be a complete sh "pipeline" consisting of many commands (see the Pipeline subsection in sh(1) for details).

Otherwise, it seems ok. Although I'm not 100% happy with the whole change. I'll comment on the original patch on the dev-commits-src-main@ mailing list.

[franco_opnsense.org]

• revert prepend wording

[franco_opnsense.org]

I reverted the change in question although I don't agree with the rationale. NAME_prepend remains a fragile construct, not being used in visible code in ports/src and prepending command(s) would imply that either ";" or "&&" is being used by default to separate the argument, which the user will not know because the documentation is not complete or the concept involved is not well-designed.

[pauamma_gundo.com]

The ${name}_prepend caveat no longer applies.

[oshogbo]

@0mp are you happy with the fixed version?