Page MenuHomeFreeBSD
Differential D36006

rc: add ${name}_setup script support
ClosedPublic
Actions

Authored by • franco_opnsense.org on Aug 1 2022, 9:36 AM.
Tags
Referenced Files
Unknown Object (File)
Wed, Jan 7, 12:34 AM
Unknown Object (File)
Tue, Jan 6, 11:38 PM
Unknown Object (File)
Mon, Jan 5, 6:27 PM
Unknown Object (File)
Fri, Jan 2, 6:16 PM
Unknown Object (File)
Fri, Jan 2, 6:16 PM
Unknown Object (File)
Fri, Jan 2, 6:16 PM
Unknown Object (File)
Sat, Dec 20, 6:25 PM
Unknown Object (File)
Sat, Dec 20, 10:11 AM
View All 81 Files
Subscribers
0mp
imp
jlduran
Contributor Reviews (src)

Details

Reviewers
oshogbo
Summary

Run a service-based setup script before running the start command.
Useful for automatic configuration file generation.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46698
Build 43587: arc lint + arc unit

Event Timeline

• franco_opnsense.org created this revision.Aug 1 2022, 9:36 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptAug 1 2022, 9:36 AM
• franco_opnsense.org requested review of this revision.Aug 1 2022, 9:36 AM
Harbormaster completed remote builds in B46698: Diff 108774.Aug 1 2022, 9:36 AM
• franco_opnsense.org added a reviewer: oshogbo.Aug 1 2022, 9:38 AM
oshogbo accepted this revision.Aug 1 2022, 9:42 AM
This revision is now accepted and ready to land.Aug 1 2022, 9:42 AM
jlduran added a subscriber: jlduran.Aug 1 2022, 4:47 PM
jlduran added inline comments.
libexec/rc/rc.subr
1156

I wonder if check_startmsgs && warn... should be prepended.

• franco_opnsense.org added a comment.Aug 2 2022, 6:43 AM

@oshogbo I don't have the means to commit so if you would pick that up when you have some time that'd be highly appreciated

libexec/rc/rc.subr
1156

Doesn't seem to be a practice with "warn". Only for raw echo in non-error condition. Wouldn't want to start that trend also for risk of hiding relevant information in some cases.

oshogbo mentioned this in rGc9be47b34dd8: rc: add ${name}_setup script support.Aug 15 2022, 2:43 PM
• franco_opnsense.org closed this revision.Aug 16 2022, 8:10 AM
pauamma_gundo.com mentioned this in D36210: rc: add a manual entry for ${name}_setup.Aug 17 2022, 7:34 AM
0mp added a project: rc.Aug 17 2022, 1:40 PM
0mp added a subscriber: 0mp.
eugen_grosbein.net mentioned this in rGed36613e65ab: rc: add ${name}_setup script support.Dec 2 2023, 8:06 AM
eugen_grosbein.net mentioned this in rGb1e0b0cb7ce1: rc: add ${name}_setup script support.Dec 2 2023, 8:39 AM

Revision Contents
Changeset List

PathSize
libexec/
rc/
14 lines

Diff 108774

View Options

libexec/rc/rc.subr

Loading...