Paths

Table of Contentst

Differential D36006

rc: add ${name}_setup script support
ClosedPublic
Actions

Authored by franco_opnsense.org on Aug 1 2022, 9:36 AM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Jul 19, 5:24 PM

	Unknown Object (File)
	Fri, Jul 5, 8:24 PM

	Unknown Object (File)
	Wed, Jul 3, 10:58 AM

	Unknown Object (File)
	Sun, Jun 30, 10:32 AM

	Unknown Object (File)
	May 1 2024, 3:05 AM

	Unknown Object (File)
	Apr 25 2024, 4:41 PM

	Unknown Object (File)
	Apr 25 2024, 4:00 PM

	Unknown Object (File)
	Apr 19 2024, 2:49 AM

View All 29 Files

Subscribers

jlduran_gmail.com

Contributor Reviews (src)

Details

Reviewers

Summary

Run a service-based setup script before running the start command.
Useful for automatic configuration file generation.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46698
Build 43587: arc lint + arc unit

Event Timeline

franco_opnsense.org created this revision.Aug 1 2022, 9:36 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptAug 1 2022, 9:36 AM

franco_opnsense.org requested review of this revision.Aug 1 2022, 9:36 AM

Harbormaster completed remote builds in B46698: Diff 108774.Aug 1 2022, 9:36 AM

franco_opnsense.org added a reviewer: oshogbo.Aug 1 2022, 9:38 AM

oshogbo accepted this revision.Aug 1 2022, 9:42 AM

This revision is now accepted and ready to land.Aug 1 2022, 9:42 AM

jlduran_gmail.com added a subscriber: jlduran_gmail.com.Aug 1 2022, 4:47 PM

jlduran_gmail.com added inline comments.

libexec/rc/rc.subr
1156	I wonder if `check_startmsgs && warn...` should be prepended.

@oshogbo I don't have the means to commit so if you would pick that up when you have some time that'd be highly appreciated

libexec/rc/rc.subr
1156	Doesn't seem to be a practice with "warn". Only for raw echo in non-error condition. Wouldn't want to start that trend also for risk of hiding relevant information in some cases.

oshogbo mentioned this in rGc9be47b34dd8: rc: add ${name}_setup script support.Aug 15 2022, 2:43 PM

franco_opnsense.org closed this revision.Aug 16 2022, 8:10 AM

pauamma_gundo.com mentioned this in D36210: rc: add a manual entry for ${name}_setup.Aug 17 2022, 7:34 AM

0mp added a project: rc.Aug 17 2022, 1:40 PM

0mp added a subscriber: 0mp.

eugen_grosbein.net mentioned this in rGed36613e65ab: rc: add ${name}_setup script support.Dec 2 2023, 8:06 AM

eugen_grosbein.net mentioned this in rGb1e0b0cb7ce1: rc: add ${name}_setup script support.Dec 2 2023, 8:39 AM

Revision Contents
Changeset List

Path

Size

libexec/

rc/

14 lines

Diff 108774

libexec/rc/rc.subr

Loading...