pf: fix failure to log correct action through default rule

[franco_opnsense.org]

Summary

The default rule is used to call PFLOG_PACKET macro and the reason
is given directly for when e.g. PFRES_SHORT is invoked and PF_DROP
is carried out. However, the action is not passed down directly so
action needs to be adjusted when the default rule made the decision
due to a non-matching reason, which means PF_DROP.

OpenBSD fix: https://github.com/openbsd/src/commit/7b8683a1743e7

[franco_opnsense.org]

style update

[franco_opnsense.org]

@kp when you said "Supporting opnsense is your job, not mine. You don’t get to just throw bugs over the wall without doing any actual testing on freebsd."[1] I'm unsure if you really meant this or if you simply don't react because it's not important to you or FreeBSD?

I can live with begging for fixes or just for them to be comitted, but I don't appreciate the attitude you have towards contributors.

[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273207

[franco_opnsense.org]

OpenBSD fix: https://github.com/openbsd/src/commit/7b8683a1743e7

[franco_opnsense.org]

switch to OpenBSD approach

[franco_opnsense.org]

Maybe fixed, who knows ;)