Page MenuHomeFreeBSD
Differential D37624

ppp: improve MSS clamping
ClosedPublic
Actions

Authored by tuexen on Dec 7 2022, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 10, 9:22 AM
Unknown Object (File)
Fri, May 8, 9:03 PM
Unknown Object (File)
Thu, May 7, 3:08 PM
Unknown Object (File)
Thu, May 7, 1:58 PM
Unknown Object (File)
Wed, May 6, 5:23 AM
Unknown Object (File)
Mon, May 4, 1:16 AM
Unknown Object (File)
Fri, May 1, 11:37 PM
Unknown Object (File)
Wed, Apr 29, 6:45 AM
View All Files
Subscribers
imp

Details

Reviewers
thj
Commits
rG301bff9bdd62: ppp: improve MSS clamping
rGcef3c4e0bab8: ppp: improve MSS clamping
Summary

ppp supports MSS clamping for TCP/IPv4. This patch

  • improves MSS clamping by correctly computing the MSS to be reported as specified in RFC 6691.
  • adds support for MSS clamping when using TCP/IPv6.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Dec 7 2022, 5:11 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 7 2022, 5:11 PM
tuexen requested review of this revision.Dec 7 2022, 5:11 PM
thj added inline comments.Dec 7 2022, 8:19 PM
usr.sbin/ppp/tcpmss.c
165

This should move into to switch statement below to be consistent with the v6 path

tuexen added inline comments.Dec 7 2022, 10:01 PM
usr.sbin/ppp/tcpmss.c
165

The reason I added the check here is that from the next line on I assume that pip points to an IP header and in the line after that I look at the first component of it. Don't I need to make sure I have at least enough data to look at the ip_v field? I think only checking in the switch statement is too late, since I have already accessed a component. Or am I wrong?

thj accepted this revision.Dec 7 2022, 10:16 PM
This revision is now accepted and ready to land.Dec 7 2022, 10:16 PM
Closed by commit rGcef3c4e0bab8: ppp: improve MSS clamping (authored by tuexen). · Explain WhyDec 8 2022, 9:10 AM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGcef3c4e0bab8: ppp: improve MSS clamping.
tuexen added a commit: rG301bff9bdd62: ppp: improve MSS clamping.Feb 2 2023, 12:04 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
ppp/
76 lines

Diff 113936

View Options

usr.sbin/ppp/tcpmss.c

Loading...