HomeFreeBSD

netmap: Address errors on memory free in netmap_generic

Description

netmap: Address errors on memory free in netmap_generic

netmap_generic keeps a pool of mbufs for handling transfers, these mbufs
have an external buffer attached to them.

If some cases other parts of the network stack can chain these mbufs,
when this happens the normal pool destructor function can end up
free'ing the pool mbufs twice:

  • A first time if a pool mbuf has been chained with another mbuf when its chain is freed
  • A second time when its entry in the pool is freed

Additionally, if other parts of the stack demote a pool mbuf its
interface reference will be cleared. In this case we deference a NULL
pointer when trying to free the mbuf through the destructor. Store a
reference to the adapter in ext_arg1 with the destructor callback so we
can find the correct adapter when free'ing a pool mbuf.

This change enables using netmap with epair interfaces.

Reviewed By: vmaffione
MFC after: 1 week
Relnotes: yes
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D44371

Details

Provenance
thjAuthored on Mar 26 2024, 9:52 AM
Reviewer
vmaffione
Differential Revision
D44371: netmap: Address errors on memory free in netmap_generic
Parents
rG39450eba8e6c: kern linker: Do not touch userrefs of the kernel file
Branches
Unknown
Tags
Unknown