As far as I can tell this is nop, but good ground work for future stuff.

This looks to do what is advertised in some simple tests. ddb is pretty fragile for me to use on the best of days so I'm happy enough

I've done a little testing and this does what I would expect on my test laptop.

Setting the regdomain on iwlwifi cleared this out - sorry for the testing delay.

I've sent test output via email. With 160MHz configured on my ap and it beaconing iwlwifi doesn't pick a vht rate for the band, just 80211a

I'm not able to convince an ap to actually do 160MHz channels - despite support in the radios.

Please commit this with "Tested by: thj".

Please add

Tested by: thj

• iwx: unlock on error path
• create a diff that can be applied on main (sorry)

No regressions I can see, iwlwifi has vht160 enabled without any configuration.

@adrian said in irc that this should have been caught with other changes. Could you test again on main?

In D49773#1153069, @bz wrote:

I've had a few people try this at least with no ill effects (though I am not sure they could test VHT160). @thj can you test the net80211 part?
I don't know otherwise what to do with it as it's been sitting here for a month now.

I unintentionally created another review with my in progress change please see D50462

• Use iwx_init on resume

Meant to add:

• use the correct pci_get_subdevice macro

• Fix nits

In D49759#1134392, @bz wrote:

PCI accessors are all there @adrian pci_get_(first column)

PCI_ACCESSOR(subvendor,         SUBVENDOR,      uint16_t)
PCI_ACCESSOR(subdevice,         SUBDEVICE,      uint16_t)
PCI_ACCESSOR(vendor,            VENDOR,         uint16_t)
PCI_ACCESSOR(device,            DEVICE,         uint16_t)
PCI_ACCESSOR(devid,             DEVID,          uint32_t)
PCI_ACCESSOR(class,             CLASS,          uint8_t)
PCI_ACCESSOR(subclass,          SUBCLASS,       uint8_t)
...

are all there.

Thanks for writing up the page! I started, but got distracted with something else. I've added some bits which will help us align to other wifi man pages

I added this to iwx to debug firmware crashes in comparison to the openbsd driver. I can move back to being a header only and out of iwx. Those crashes aren't happening anymore with the move to the fc release

• Update copyright statements based on advice from review

"GPL-2.0" without only isn't in the spdx license list so I would like to avoid that. I think only here means "not and later" rather than it being a file exclusively licensed with the gpl.

I'm waiting for an ack on spdx tags from @emaste or @imp and I'm not going to commit at 4 on a Friday :D

• Add spdx tags and FreeBSD Foundation Copyright

• rewrite channel map with patch from bz
• Add more printing to rate debugging
• Add an ignore around payload_len

• Comment out debug flags
• Remove FreeBSD revision specifier
• Move iwx to be in the sourcelss block with other intel drivers
• Remove unused functions from build

• Tidy up headers
• Split out debug.h
• Fix build without debug
• Manage firmware lifetimes better
• Change probe priority

• Use iwlwifi names for firmware files
• Parameterise iwx in the modules makefile
• Remove a debug panic

I'm happy with the ieee80211 and driver changes, but bz@ should respond for the linuxkpi as he has all the experience there.

I think that dot11rate should be a uint8_t, but you can change it on commit if you agree