I have a temp fix for this directly in ice and will work with erj@ to have the driver support the vlan ifconfig flags correctly

Thanks both for the comments, I didn't think this would be the correct approach, but it seemed easier to create a review for how I would like this to work.

Please fix the man page typo, but otherwise looks good to me

• access ext_arg1 via the accessor

updated

• swap order of arguments for destructor
• replace an m_freem with m_free

• Correct copyright statement
• Move then for if statements onto the same line

In D44371#1013215, @vmaffione wrote:

Any additional tests with pkt-gen in TX or RX mode over iflib interfaces and virtio-net ones?
E.g. two VMs/machines connected back to back with one transmitting and the other receiving, to stress test it?
Setting the sys.dev.netmap.admode sysctl to 2 will force emulated netmap even if the interface has native support.

• Add a macro for getting netmap adapter from ext_arg1

• - use SET_MBUF_DESTRUCTOR to set ext_arg1

• - Don't remove the pool lock until we have removed all mbufs

• - if the reference has gone after taking the lock don't free the mbuf

Address review comments

Add to Makefile

add call to pft_init

Use immediate mode for tcpdump
enhance comments

Fix tcpdump test

Address Kyles review comments

• Address further comments from Mark

• Remove asan from makefiles

• Ensure there are enough bytes following the icmp header

• move libdiff into contrib

• use a RDTUN sysctl rather than a hint
• Use a global control for cppc notifications

• Simplify hint name

• Add a hint to disable the workaround

Update to building version

Looks good to me

• make strnsubst return a bool indicating if truncation occured

simplfy the eflag based on suggestions by dim