Details

Reviewers

bz
thj

Group Reviewers

wireless

Commits

rG46de4d9fc21d: net80211: change ieee80211_ratectl_rate() to not return a rix

Summary

There are only a few places where the returned rix is used:

linuxkpi - logging
bwi/bwn - used for finding a fallback rate to choose, which honestly should be returned by the ratectl API
iwm - building the rateset to program into firmware

Everyone else uses the dot11rate value in ni->ni_txnode.

This is a precursor for VHT and later rate support; where currently
there aren't rate tables in ieee80211_phy.c for VHT and later
rates.

Although it's likely doable to add tables for VHT, 11ax and MU-OFDMA
(HE) rates are sufficiently larger/different to just not fit in the
current scheme without more refactoring.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Jan 23 2025, 2:35 AM

Herald added subscribers: linuxkpi, glebius, melifaro and 2 others. · View Herald TranscriptJan 23 2025, 2:35 AM

adrian requested review of this revision.Jan 23 2025, 2:35 AM

Harbormaster completed remote builds in B61894: Diff 149732.Jan 23 2025, 2:35 AM

adrian added a parent revision: D48602: sys: convert ni->ni_txrate references use to the new net80211 API.Jan 23 2025, 2:35 AM

adrian added a child revision: D48604: net80211: convert ni_txrate to a struct, with extra rate information.

adrian added a reviewer: wireless.Jan 23 2025, 3:02 AM

adrian added a project: wireless.

rebsae

Harbormaster completed remote builds in B61954: Diff 149843.Jan 24 2025, 1:50 AM

rebase

Harbormaster completed remote builds in B61981: Diff 149895.Jan 24 2025, 3:31 PM

thj added a subscriber: thj.Jan 24 2025, 4:22 PM

thj added inline comments.

sys/compat/linuxkpi/common/src/linux_80211.c
6948	This cast isn't needed

adrian added inline comments.Jan 25 2025, 8:33 PM

sys/compat/linuxkpi/common/src/linux_80211.c
6948	I'm so used to using/building in envs where you get a warning if you don't handle the return value. :-) Lemme go make sure that doesn't happen here on all of our branches and then I'll go remove em all.

bz requested changes to this revision.Jan 26 2025, 10:31 PM

bz added a subscriber: bz.

bz added inline comments.

sys/compat/linuxkpi/common/src/linux_80211.c
6948	remove it!
sys/dev/iwm/if_iwm.c
4582	Please declare within proper scope or pass the result from the function to the next w/o variable. A dot11rate is an uint8_t anyway
sys/net80211/ieee80211_ratectl.h
135	Cast not needed.