Page MenuHomeFreeBSD

net80211: refactor amrr_update() into HT and legacy paths
Needs ReviewPublic

Authored by adrian on Sun, Dec 29, 7:41 PM.

Details

Reviewers
None
Group Reviewers
wireless
Summary

Split the amrr_update() routine into HT and legacy paths.
Currently they're the same, minus HT / non-HT specific comments
and some logging changes.

HT rates don't monotonically go up (ie, going MCS 7 -> MCS 8 is wrong,
as MCS8 is "just" two stream MCS0) and failing a rate by a little
shouldn't necessarily preclude testing the next rate up.

This should be a no-op, besides the logging changes.

Locally tested:

  • RTL8192CU, STA mode

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61396
Build 58280: arc lint + arc unit

Event Timeline

Note: the goal here is to create a third path for VHT rates, even if it's making inefficient choices.

I have a local diff here that I'm not putting up for review (yet!) that turns it from an rix +/- change into a table based change, so we can configure which MCS rates it steps up / down through. It's a lot easier to do that with amrr refactored and cleaned up.