Differential D48609

net80211: add node VHT transmit rate helper functions
ClosedPublic
Actions

Authored by adrian on Jan 23 2025, 2:38 AM.

Tags

Referenced Files

	F142364641: D48609.id151525.diff
	Mon, Jan 19, 3:13 AM

	Unknown Object (File)
	Sat, Jan 17, 3:21 AM

	Unknown Object (File)
	Fri, Jan 16, 8:31 PM

	Unknown Object (File)
	Fri, Jan 16, 8:29 PM

	Unknown Object (File)
	Wed, Jan 14, 11:45 AM

	Unknown Object (File)
	Wed, Jan 14, 11:10 AM

	Unknown Object (File)
	Mon, Jan 12, 3:04 PM

	Unknown Object (File)
	Fri, Dec 26, 8:29 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG1086f7bab303: net80211: add node VHT transmit rate helper functions

Summary

add a node VHT transmit function, which configures the parameters accordingly.

add a node VHT transmit function which just copies in another ieee80211_node_txrate struct.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Jan 23 2025, 2:38 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJan 23 2025, 2:38 AM

adrian requested review of this revision.Jan 23 2025, 2:38 AM

Harbormaster completed remote builds in B61900: Diff 149738.Jan 23 2025, 2:39 AM

adrian added a parent revision: D48608: net80211: add valid VHT MCS combinations and helper functions.Jan 23 2025, 2:39 AM

adrian added a parent revision: D48610: net80211: add ieee80211_vht_node_check_valid_mcs().

adrian removed a parent revision: D48610: net80211: add ieee80211_vht_node_check_valid_mcs().

adrian added a child revision: D48610: net80211: add ieee80211_vht_node_check_valid_mcs().

adrian added a reviewer: wireless.Jan 23 2025, 3:05 AM

adrian added a project: wireless.

rebase

Harbormaster completed remote builds in B61960: Diff 149849.Jan 24 2025, 1:52 AM

rebase

Harbormaster completed remote builds in B61987: Diff 149901.Jan 24 2025, 3:31 PM

rebase, address changes

Harbormaster completed remote builds in B62053: Diff 150005.Jan 27 2025, 12:16 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62116: Diff 150151.Jan 30 2025, 5:15 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62131: Diff 150166.Jan 30 2025, 5:16 AM

add MPASS()

Harbormaster completed remote builds in B62450: Diff 151044.Feb 14 2025, 4:45 PM

Apart from the consistency I am fine with this too.

sys/net80211/ieee80211_node.c
3274	I am confused by argument order here. Even below they are assigned in different order. Can we for consistency always have one first and the other second and not one this one that? It'll save accidents.

bz accepted this revision as: bz.Feb 16 2025, 8:54 PM

bz added inline comments.

sys/net80211/ieee80211_node.c
3274	Turns out it's left/first or right/second depending on where to look. So maybe ignore this. Case might be lost.

This revision is now accepted and ready to land.Feb 16 2025, 8:54 PM

Closed by commit rG1086f7bab303: net80211: add node VHT transmit rate helper functions (authored by adrian). · Explain WhyFeb 26 2025, 7:32 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG1086f7bab303: net80211: add node VHT transmit rate helper functions.

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_node.h

4 lines

ieee80211_node.c

40 lines

Diff 151525

sys/net80211/ieee80211_node.h

Loading...

sys/net80211/ieee80211_node.c

Loading...