Page MenuHomeFreeBSD

net80211: migrate ieee80211_rate2media() to use ieee80211_node_txrate
ClosedPublic

Authored by adrian on Jan 23 2025, 2:45 AM.
Referenced Files
Unknown Object (File)
Sat, Mar 1, 3:28 AM
Unknown Object (File)
Thu, Feb 27, 12:37 AM
Unknown Object (File)
Thu, Feb 13, 9:13 PM
Unknown Object (File)
Tue, Feb 11, 11:31 AM
Unknown Object (File)
Tue, Feb 11, 12:22 AM
Unknown Object (File)
Mon, Feb 10, 10:56 PM
Unknown Object (File)
Sat, Feb 8, 5:34 PM
Unknown Object (File)
Sat, Feb 8, 12:04 PM

Details

Summary

This is one of the two obvious left-over dot11rate lookups that trigger
a debug print. (The other is get_sta_info()).

  • Change ieee80211_rate2media() to use the passed in ieee80211_node_txrate and use the rate type field to see if it's legacy/ht or vht.
  • .. and (I hope!) actually handle the VHT rate correctly.
  • Change the callers of ieee80211_rate2media() to use the new static initialisers.

For the one spot in ieee80211_ht.c which uses the HT initialiser, it should
just be a straight up mechanical change that correctly sets the HT MCS
rate.

For the rest of them in ieee80211.c, they're doing table initialisation
for the media types / rates, and it's currently very focused on legacy
rates. So just leave that all as-is for now with a mechanical change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

thj added a subscriber: thj.
thj added inline comments.
sys/net80211/ieee80211.c
2735

Don't add the extra newline when this lands

This revision is now accepted and ready to land.Jan 28 2025, 10:09 AM
This revision now requires review to proceed.Jan 30 2025, 5:16 AM
bz requested changes to this revision.Sat, Feb 22, 11:22 AM
bz added a subscriber: bz.
bz added inline comments.
sys/net80211/ieee80211.c
2540

int m, rate;

2576

Variable declaration above.

This revision now requires changes to proceed.Sat, Feb 22, 11:22 AM

updated, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Feb 26, 7:32 PM
This revision was automatically updated to reflect the committed changes.