Page MenuHomeFreeBSD

net80211: migrate ieee80211_rate2media() to use ieee80211_node_txrate
Needs ReviewPublic

Authored by adrian on Thu, Jan 23, 2:45 AM.
Referenced Files
F109257849: D48615.diff
Sun, Feb 2, 5:12 PM
F109236742: D48615.id150174.diff
Sun, Feb 2, 10:56 AM
F109211618: D48615.id.diff
Sun, Feb 2, 3:02 AM
Unknown Object (File)
Fri, Jan 31, 3:14 PM
Unknown Object (File)
Thu, Jan 30, 3:01 AM
Unknown Object (File)
Wed, Jan 29, 2:13 PM
Unknown Object (File)
Tue, Jan 28, 4:20 PM
Unknown Object (File)
Tue, Jan 28, 4:10 PM

Details

Reviewers
thj
Group Reviewers
wireless
Summary

This is one of the two obvious left-over dot11rate lookups that trigger
a debug print. (The other is get_sta_info()).

  • Change ieee80211_rate2media() to use the passed in ieee80211_node_txrate and use the rate type field to see if it's legacy/ht or vht.
  • .. and (I hope!) actually handle the VHT rate correctly.
  • Change the callers of ieee80211_rate2media() to use the new static initialisers.

For the one spot in ieee80211_ht.c which uses the HT initialiser, it should
just be a straight up mechanical change that correctly sets the HT MCS
rate.

For the rest of them in ieee80211.c, they're doing table initialisation
for the media types / rates, and it's currently very focused on legacy
rates. So just leave that all as-is for now with a mechanical change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62139
Build 59023: arc lint + arc unit

Event Timeline

thj added a subscriber: thj.
thj added inline comments.
sys/net80211/ieee80211.c
2735

Don't add the extra newline when this lands

This revision is now accepted and ready to land.Tue, Jan 28, 10:09 AM
This revision now requires review to proceed.Thu, Jan 30, 5:16 AM