Page MenuHomeFreeBSD
Differential D48602

sys: convert ni->ni_txrate references use to the new net80211 API
Needs ReviewPublic
Actions

Authored by adrian on Thu, Jan 23, 2:35 AM.
Tags
Referenced Files
Unknown Object (File)
Wed, Feb 12, 1:32 AM
Unknown Object (File)
Sun, Feb 9, 10:41 PM
Unknown Object (File)
Sat, Feb 8, 1:41 AM
Unknown Object (File)
Thu, Feb 6, 11:11 PM
Unknown Object (File)
Wed, Feb 5, 8:41 PM
Unknown Object (File)
Tue, Feb 4, 1:56 AM
Unknown Object (File)
Sun, Feb 2, 12:17 PM
Unknown Object (File)
Sun, Feb 2, 11:09 AM
View All 16 Files
Subscribers
bz
emaste
gavin
imp
thj
linuxkpi

Details

Reviewers
bz
Group Reviewers
wireless
Summary

This just mechanically converts things.

  • For linuxkpi, it was just used for display.
  • For uath, it was just used for display, as firmware doesn't report it up.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62336
Build 59220: arc lint + arc unit

Event Timeline

adrian created this revision.Thu, Jan 23, 2:35 AM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptThu, Jan 23, 2:35 AM
adrian requested review of this revision.Thu, Jan 23, 2:35 AM
Harbormaster completed remote builds in B61893: Diff 149731.Thu, Jan 23, 2:35 AM
adrian added a parent revision: D48601: net80211: remove direct use of ni->ni_txrate, add indirection methods.Thu, Jan 23, 2:35 AM
adrian added a child revision: D48603: net80211: change ieee80211_ratectl_rate() to not return a rix.
adrian added a reviewer: wireless.Thu, Jan 23, 3:01 AM
adrian added a project: wireless.
thj added a subscriber: thj.Thu, Jan 23, 4:28 PM
thj added inline comments.
sys/dev/ath/ath_rate/onoe/onoe.c
394

Shouldn't this be divided by 2 if the rate is returned in 500kbit units?

adrian updated this revision to Diff 149842.Fri, Jan 24, 1:50 AM

rebase

Harbormaster completed remote builds in B61953: Diff 149842.Fri, Jan 24, 1:50 AM
adrian updated this revision to Diff 149894.Fri, Jan 24, 3:30 PM

rebase

Harbormaster completed remote builds in B61980: Diff 149894.Fri, Jan 24, 3:31 PM
bz requested changes to this revision.Sun, Jan 26, 10:23 PM
bz added a subscriber: bz.
bz added inline comments.
sys/dev/ath/ath_rate/onoe/onoe.c
206

uint8_t

394

This is sorted but nor marked as done?

sys/dev/ipw/if_ipw.c
841

Funny that iwi right below holds the reference over this but ipw did not...

sys/dev/mwl/if_mwl.c
3347

Can this be an uint8_t or does it have to stay int? ( I haven't checked the surrounding code )

sys/dev/wtap/if_wtap.c
620

Is there a leading blank here?

This revision now requires changes to proceed.Sun, Jan 26, 10:23 PM
adrian updated this revision to Diff 149998.Mon, Jan 27, 12:15 AM

rebase, address changes

Harbormaster completed remote builds in B62046: Diff 149998.Mon, Jan 27, 12:15 AM
adrian added inline comments.Wed, Jan 29, 4:26 AM
sys/dev/ath/ath_rate/onoe/onoe.c
394

it's really kbit now, not 1/2mbit

sys/dev/ipw/if_ipw.c
841

Yeah this wasn't ever consistent. A lot (and I mean a /lot/) of hilarity in crashes in the past due to the node refcounting/garbage collecting locking changes same did years ago.

It would be great to also clean this stuff up and make it consistent.

sys/dev/mwl/if_mwl.c
3347

I think it's a HW field first, not a dot11rate

gavin added a subscriber: gavin.Wed, Jan 29, 9:25 PM
gavin added inline comments.
sys/dev/ath/ath_rate/onoe/onoe.c
225–227

Extra trailing brace?

adrian updated this revision to Diff 150138.Thu, Jan 30, 12:45 AM
adrian marked 4 inline comments as done.

update, fix things from gavin/bz

Harbormaster completed remote builds in B62104: Diff 150138.Thu, Jan 30, 12:45 AM
adrian marked 2 inline comments as done.Thu, Jan 30, 12:46 AM

fixed, please re-review!

sys/dev/wtap/if_wtap.c
620

nope, just a tab!

adrian updated this revision to Diff 150144.Thu, Jan 30, 5:14 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62109: Diff 150144.Thu, Jan 30, 5:14 AM
adrian updated this revision to Diff 150159.Thu, Jan 30, 5:15 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62124: Diff 150159.Thu, Jan 30, 5:15 AM
adrian updated this revision to Diff 150788.Mon, Feb 10, 8:13 PM

add mtw, now that it landed in -head

Harbormaster completed remote builds in B62336: Diff 150788.Mon, Feb 10, 8:13 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
src/
6 lines
dev/
ath/
ath_rate/
amrr/
7 lines
onoe/
8 lines
sample/
9 lines
bwi/
2 lines
bwn/
2 lines
ipw/
4 lines
iwi/
4 lines
iwm/
9 lines
iwn/
2 lines
malo/
2 lines
mwl/
11 lines
otus/
9 lines
ral/
4 lines
4 lines
2 lines
rtwn/
2 lines
usb/
wlan/
10 lines
3 lines
2 lines
7 lines
3 lines
2 lines
2 lines
wpi/
2 lines
wtap/
5 lines

Diff 150788

View Options

sys/compat/linuxkpi/common/src/linux_80211.c

Loading...
View Options

sys/dev/ath/ath_rate/amrr/amrr.c

Loading...
View Options

sys/dev/ath/ath_rate/onoe/onoe.c

Loading...
View Options

sys/dev/ath/ath_rate/sample/sample.c

Loading...
View Options

sys/dev/bwi/if_bwi.c

Loading...
View Options

sys/dev/bwn/if_bwn.c

Loading...
View Options

sys/dev/ipw/if_ipw.c

Loading...
View Options

sys/dev/iwi/if_iwi.c

Loading...
View Options

sys/dev/iwm/if_iwm.c

Loading...
View Options

sys/dev/iwn/if_iwn.c

Loading...
View Options

sys/dev/malo/if_malo.c

Loading...
View Options

sys/dev/mwl/if_mwl.c

Loading...
View Options

sys/dev/otus/if_otus.c

Loading...
View Options

sys/dev/ral/rt2560.c

Loading...
View Options

sys/dev/ral/rt2661.c

Loading...
View Options

sys/dev/ral/rt2860.c

Loading...
View Options

sys/dev/rtwn/if_rtwn_tx.c

Loading...
View Options

sys/dev/usb/wlan/if_mtw.c

Loading...
View Options

sys/dev/usb/wlan/if_rsu.c

Loading...
View Options

sys/dev/usb/wlan/if_rum.c

Loading...
View Options

sys/dev/usb/wlan/if_run.c

Loading...
View Options

sys/dev/usb/wlan/if_uath.c

Loading...
View Options

sys/dev/usb/wlan/if_ural.c

Loading...
View Options

sys/dev/usb/wlan/if_zyd.c

Loading...
View Options

sys/dev/wpi/if_wpi.c

Loading...
View Options

sys/dev/wtap/if_wtap.c

Loading...