sys: convert ni->ni_txrate references use to the new net80211 API

[adrian]

Summary

This just mechanically converts things.

• For linuxkpi, it was just used for display.
• For uath, it was just used for display, as firmware doesn't report it up.

[thj]

sys/dev/ath/ath_rate/onoe/onoe.c

394

Shouldn't this be divided by 2 if the rate is returned in 500kbit units?

[adrian]

rebase

[adrian]

rebase

[bz]

sys/dev/ath/ath_rate/onoe/onoe.c

206

uint8_t

394

This is sorted but nor marked as done?

sys/dev/ipw/if_ipw.c

841

Funny that iwi right below holds the reference over this but ipw did not...

sys/dev/mwl/if_mwl.c

3347

Can this be an uint8_t or does it have to stay int? ( I haven't checked the surrounding code )

sys/dev/wtap/if_wtap.c

620

Is there a leading blank here?

[adrian]

rebase, address changes

[adrian]

sys/dev/ath/ath_rate/onoe/onoe.c

394

it's really kbit now, not 1/2mbit

sys/dev/ipw/if_ipw.c

841

Yeah this wasn't ever consistent. A lot (and I mean a /lot/) of hilarity in crashes in the past due to the node refcounting/garbage collecting locking changes same did years ago.

It would be great to also clean this stuff up and make it consistent.

sys/dev/mwl/if_mwl.c

3347

I think it's a HW field first, not a dot11rate

[gavin]

sys/dev/ath/ath_rate/onoe/onoe.c

225–227

Extra trailing brace?

[adrian]

update, fix things from gavin/bz

[adrian]

fixed, please re-review!

sys/dev/wtap/if_wtap.c

620

nope, just a tab!

[adrian]

update, add TXRATE_HT

[adrian]

update, add TXRATE_HT

[adrian]

add mtw, now that it landed in -head

[thj]

I think that dot11rate should be a uint8_t, but you can change it on commit if you agree

sys/dev/ath/ath_rate/amrr/amrr.c

248–252

[bz]

sys/dev/ath/ath_rate/amrr/amrr.c

248–252

@adrian this still needs to be addressed?

sys/dev/ath/ath_rate/sample/sample.c

858–864

Is this actually correct still or does it need to be (pseudo-code)?

if (HT)
   ieee80211_node_set_txrate_ht_mcsrate
else
   ieee80211_node_set_txrate_dot11rate

sys/dev/iwm/if_iwm.c

3454

This could move down to line 3467 (next to tx_resp_rate).

sys/dev/usb/wlan/if_mtw.c

2165

This is probably wrong and should go under 2212 once rate control is done?

[bz]

@adrian did you miss this one? It has some question from thj and me open now. If this gets sorted then the first four of your stack are in :) I'll do the next ones now.

[adrian]

In D48602#1117904, @bz wrote:

@adrian did you miss this one? It has some question from thj and me open now. If this gets sorted then the first four of your stack are in :) I'll do the next ones now.

I'm still getting to em :)

[adrian]

address some more comments from thj/bz

sys/dev/ath/ath_rate/sample/sample.c

858–864

fwiw, dot11rate still works fine for HT and legacy.