Page MenuHomeFreeBSD
Differential D48608

net80211: add valid VHT MCS combinations and helper functions
AcceptedPublic
Actions

Authored by adrian on Jan 23 2025, 2:38 AM.
Tags
Referenced Files
Unknown Object (File)
Sat, Feb 15, 3:01 PM
Unknown Object (File)
Wed, Feb 12, 1:24 AM
Unknown Object (File)
Sat, Feb 8, 9:59 AM
Unknown Object (File)
Sat, Feb 8, 9:28 AM
Unknown Object (File)
Tue, Feb 4, 11:25 PM
Unknown Object (File)
Tue, Feb 4, 7:31 PM
Unknown Object (File)
Tue, Feb 4, 5:29 PM
Unknown Object (File)
Tue, Feb 4, 7:37 AM
View All 27 Files
Subscribers
bz
glebius
imp
melifaro

Details

Reviewers
bz
Group Reviewers
wireless
Summary

Not all NSS / MCS / channel bandwidth combinations are valid.

This will be important for rate control and transmit rate
setup (eg static management, unicast, multicast rates.)

This is based on 802.11-2020 Section 21.5 (Parameters for VHT-MCSs.)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62130
Build 59014: arc lint + arc unit

Event Timeline

adrian created this revision.Jan 23 2025, 2:38 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJan 23 2025, 2:38 AM
adrian requested review of this revision.Jan 23 2025, 2:38 AM
Harbormaster completed remote builds in B61899: Diff 149737.Jan 23 2025, 2:38 AM
adrian added a parent revision: D48607: net80211: Implement ieee80211_setup_vht_rates().Jan 23 2025, 2:38 AM
adrian added a child revision: D48609: net80211: add node VHT transmit rate helper functions.
adrian added a reviewer: wireless.Jan 23 2025, 3:04 AM
adrian added a project: wireless.
adrian updated this revision to Diff 149848.Jan 24 2025, 1:51 AM

rebase

Harbormaster completed remote builds in B61959: Diff 149848.Jan 24 2025, 1:51 AM
adrian updated this revision to Diff 149900.Fri, Jan 24, 3:31 PM

rebase

Harbormaster completed remote builds in B61986: Diff 149900.Fri, Jan 24, 3:31 PM
adrian updated this revision to Diff 150004.Mon, Jan 27, 12:16 AM

rebase, address changes

Harbormaster completed remote builds in B62052: Diff 150004.Mon, Jan 27, 12:16 AM
adrian updated this revision to Diff 150150.Thu, Jan 30, 5:15 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62115: Diff 150150.Thu, Jan 30, 5:15 AM
adrian updated this revision to Diff 150165.Thu, Jan 30, 5:16 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62130: Diff 150165.Thu, Jan 30, 5:16 AM
bz added a subscriber: bz.Sun, Feb 16, 7:27 PM

I am fine with this either way. If you don't want to change this is accepted too.

sys/net80211/ieee80211_phy.c
680

Surprised you don't use a default here for future-proof-ness.

adrian added inline comments.Sun, Feb 16, 10:11 PM
sys/net80211/ieee80211_phy.c
680

I want the compiler to complain, it's an enum, right? :)

bz accepted this revision.Sun, Feb 16, 10:15 PM
bz added inline comments.
sys/net80211/ieee80211_phy.c
680

Do you ever expect more supported bw in VHT? Fine by me either way.

This revision is now accepted and ready to land.Sun, Feb 16, 10:15 PM
adrian added a comment.Sun, Feb 16, 10:19 PM

Not for VHT, but who knows what we'll end up doing for EHT/HE, what we want to do for half/quarter rates, etc.

Right now ni_chw is the protocol width in the IE, not specifically whatever the PHY is configured as. All kinds of fun stuff may happen in the future!

Revision Contents
Changeset List

PathSize
sys/
net80211/
7 lines
86 lines

Diff 150165

View Options

sys/net80211/ieee80211_phy.h

Loading...
View Options

sys/net80211/ieee80211_phy.c

Loading...