Page MenuHomeFreeBSD

imx_gpio: Add compat string for imx8mp
ClosedPublic

Authored by thj on Sep 4 2024, 3:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 10, 8:39 PM
Unknown Object (File)
Dec 9 2024, 2:35 AM
Unknown Object (File)
Nov 21 2024, 11:46 PM
Unknown Object (File)
Nov 21 2024, 11:45 PM
Unknown Object (File)
Nov 21 2024, 11:45 PM
Unknown Object (File)
Nov 21 2024, 11:45 PM
Unknown Object (File)
Nov 21 2024, 11:07 PM
Unknown Object (File)
Nov 18 2024, 3:59 PM
Subscribers

Details

Test Plan

On the Olimex IMX8MP-SOM+EVK I can toggle the exposed GPIO's in GPIO bus 0
(gpio 1 in the schematic). This is all the change I need to for pin control in
other drivers, but that bus is the only think I can poke with a multimeter.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

thj requested review of this revision.Sep 4 2024, 3:38 PM

Any idea why it have a different compatible string ?
Is this because only of features that we don't use ?
Have you tested interrupts ?

Any idea why it have a different compatible string ?
Is this because only of features that we don't use ?

I have no idea why they are adding more and more compat strings. imx8mq and imx8mp are very similar, but they don't seem to share compat in the dtsi files. There is some sharing with imx8mm.

Compat for gpio from imx8mp.dtsi is:

compatible = "fsl,imx8mp-gpio", "fsl,imx35-gpio";

Have you tested interrupts ?

I hadn't but I have now. I used gpioevents from tools/test and I get events from the controller so that seems to work.

manu requested changes to this revision.Sep 5 2024, 8:18 AM
In D46532#1060977, @thj wrote:

Any idea why it have a different compatible string ?
Is this because only of features that we don't use ?

I have no idea why they are adding more and more compat strings. imx8mq and imx8mp are very similar, but they don't seem to share compat in the dtsi files. There is some sharing with imx8mm.

Compat for gpio from imx8mp.dtsi is:

compatible = "fsl,imx8mp-gpio", "fsl,imx35-gpio";

So it could be that they added the specific SoC binding "just in case", maybe it would be better to add fsl,imx35-gpio to our compat table ?

Have you tested interrupts ?

I hadn't but I have now. I used gpioevents from tools/test and I get events from the controller so that seems to work.

Good, thanks

This revision now requires changes to proceed.Sep 5 2024, 8:18 AM

Use imx35-gpio rather than the soc specific compat string

Don't forget to change commit message.

This revision is now accepted and ready to land.Sep 5 2024, 12:55 PM
This revision was automatically updated to reflect the committed changes.