iconv: only conditionally use ICONV_SET_DISCARD_ILSEQ
ClosedPublic
Actions

Authored by kevans on Feb 22 2022, 5:25 PM.

Details

Reviewers

jrtc27
emaste
thj

Group Reviewers

Klara

Commits

rGea0f37dec65d: iconv: only conditionally use ICONV_SET_DISCARD_ILSEQ

Summary

If the -c flag is used, then we can set it with ICONV_SET_DISCARD_ILSEQ;
otherwise, leave it alone. The user may have specified //IGNORE in the
'to' codeset specification, there's no reason we can't allow that but
we'll currently turn it off.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Feb 22 2022, 5:25 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 22 2022, 5:25 PM

kevans requested review of this revision.Feb 22 2022, 5:25 PM

Harbormaster completed remote builds in B44535: Diff 103109.Feb 22 2022, 5:25 PM

kevans added a child revision: D34343: libc: iconv: push option ignore into citrus_iconv_open().Feb 22 2022, 5:25 PM

Looks good to me

This revision is now accepted and ready to land.Aug 2 2022, 12:17 PM

Closed by commit rGea0f37dec65d: iconv: only conditionally use ICONV_SET_DISCARD_ILSEQ (authored by kevans). · Explain WhyAug 11 2022, 4:44 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGea0f37dec65d: iconv: only conditionally use ICONV_SET_DISCARD_ILSEQ.

Revision Contents
Changeset List

Path

Size

usr.bin/

iconv/

iconv.c

13 lines

Diff 109192

View Options

iconv: only conditionally use ICONV_SET_DISCARD_ILSEQClosedPublicActions