renice: Factor out common code in tests.
ClosedPublic
Actions

Authored by des on Apr 18 2023, 11:51 AM.

Tags

None

Referenced Files

	F153493293: D39650.diff
	Tue, Apr 21, 11:21 AM

	F153481588: D39650.diff
	Tue, Apr 21, 10:05 AM

	Unknown Object (File)
	Sun, Apr 19, 7:22 PM

	Unknown Object (File)
	Thu, Apr 16, 10:20 AM

	Unknown Object (File)
	Mon, Apr 13, 9:45 PM

	Unknown Object (File)
	Sat, Apr 11, 1:19 PM

	Unknown Object (File)
	Sat, Apr 11, 2:11 AM

	Unknown Object (File)
	Wed, Apr 8, 1:31 PM

View All Files

Subscribers

imp

Details

Reviewers

thj

Group Reviewers

Klara

Commits

rG1bc6dcc287fa: renice: Factor out common code in tests.

Summary

Furthermore, prefer test -eq (which ignores whitespace) over a strict string equality test when comparing numerical values.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Apr 18 2023, 11:51 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 18 2023, 11:51 AM

des requested review of this revision.Apr 18 2023, 11:51 AM

Harbormaster completed remote builds in B50998: Diff 120557.Apr 18 2023, 11:51 AM

thj accepted this revision.Apr 18 2023, 12:22 PM

This revision is now accepted and ready to land.Apr 18 2023, 12:22 PM

Closed by commit rG1bc6dcc287fa: renice: Factor out common code in tests. (authored by des). · Explain WhyApr 18 2023, 5:15 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG1bc6dcc287fa: renice: Factor out common code in tests..

des mentioned this in rG7c067d5b823d: renice: Avoid segfault if -n flag is given without argument..May 6 2023, 2:42 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

renice/

tests/

renice_test.sh

34 lines

Diff 120574

View Options

usr.bin/renice/tests/renice_test.sh

renice: Factor out common code in tests.ClosedPublicActions