Page MenuHomeFreeBSD

net80211: convert the rest of the native net80211 drivers to SEQNO_OFFLOAD
ClosedPublic

Authored by adrian on Jun 10 2025, 4:26 AM.
Referenced Files
Unknown Object (File)
Mon, Sep 29, 12:02 PM
Unknown Object (File)
Sun, Sep 21, 3:35 PM
Unknown Object (File)
Sun, Sep 21, 12:31 PM
Unknown Object (File)
Sep 9 2025, 7:51 AM
Unknown Object (File)
Sep 7 2025, 6:48 AM
Unknown Object (File)
Sep 7 2025, 5:26 AM
Unknown Object (File)
Sep 6 2025, 5:37 AM
Unknown Object (File)
Sep 4 2025, 9:34 AM
Subscribers

Details

Summary
  • Convert the rest of the drivers to implement driver/offloaded sequence number handling.
  • For drivers that implement their own sequence number space handling for A-MPDU, only call ieee80211_output_seqno_assign() if the frame isn't tagged with M_AMPDU_MPDU, which mirrors the original net80211 sequence number behaviour. (Except of course, the assignment is now happening during final encap/transmit, not early in encap.)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66581
Build 63464: arc lint + arc unit

Event Timeline

adrian added a project: wireless.

note: i haven't yet tested iwi, bwi, bwn - but i found the hardware, so i'll test it next week.
everything else has been tested.

Again; you know the drivers better; I was wondering about iwm; are we sure this is true for all cases?

sys/dev/iwm/if_iwm.c
6146

Have you tested this? Is it true for all cases?

bz requested changes to this revision.Aug 19 2025, 9:36 PM
bz added inline comments.
sys/dev/iwm/if_iwm.c
6146

I do believe you would have to set it yourself but given there is no 11n support here... As-is is wrong. I would probably not set the flag? Or leave a comment at least?

This revision now requires changes to proceed.Aug 19 2025, 9:36 PM
sys/dev/iwm/if_iwm.c
6146

I've tested it on all the iwm hardware i have here, it seems to work fine

oops, forgot to add iwn(4)

Testing I leave to you then; you know these devices and drivers better than I do. Scrolling through looked ok.

This revision is now accepted and ready to land.Sat, Sep 20, 2:13 AM