Page MenuHomeFreeBSD

iwx: don't log VHT rate lookups in iwx_tx_fill_cmd() for data frames
ClosedPublic

Authored by adrian on Sep 28 2025, 3:17 AM.
Referenced Files
Unknown Object (File)
Tue, Nov 25, 2:26 PM
Unknown Object (File)
Wed, Nov 19, 5:09 PM
Unknown Object (File)
Wed, Nov 19, 5:07 PM
Unknown Object (File)
Sun, Nov 16, 11:06 AM
Unknown Object (File)
Sun, Nov 16, 1:04 AM
Unknown Object (File)
Fri, Nov 14, 7:40 PM
Unknown Object (File)
Thu, Nov 13, 10:44 AM
Unknown Object (File)
Sun, Nov 9, 10:22 PM
Subscribers

Details

Summary

iwx is now logging a lot of stuff to the kernel when associated at VHT
rates. It's my fault; the replacement tx rate APIs print out a warning
when you're handing the legacy rate /HT rate APIs a VHT rate.

However all of the supported chipsets in iwx will be pushing the
rate control entirely into firmware. We don't need to do per-frame
TX rate control like in previous chips.

So for now, just put in an if (rate == VHT) into the path and
a TODO comment. A few lines later the function will just skip the
rate assignment stuff for data frames, thus saving us the logging.
The other paths (control traffic, multicast traffic) uses legacy
rates / HT rates by default and won't trigger a warning log.

Yes, iwx_tx_fill_cmd() really does deserve a rate control logic
rewrite, but I want to fix this particular issue first.

Locally tested:

  • AX210, STA mode, HT and VHT associations

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 30 2025, 10:10 AM