Page MenuHomeFreeBSD

rtwn: enable seqno offload
AbandonedPublic

Authored by adrian on Jun 5 2025, 12:48 AM.
Referenced Files
Unknown Object (File)
Sun, Oct 12, 12:35 PM
Unknown Object (File)
Fri, Oct 10, 11:50 AM
Unknown Object (File)
Fri, Oct 3, 5:24 PM
Unknown Object (File)
Thu, Oct 2, 4:57 PM
Unknown Object (File)
Tue, Sep 30, 8:50 AM
Unknown Object (File)
Sun, Sep 21, 8:57 PM
Unknown Object (File)
Sep 7 2025, 4:23 AM
Unknown Object (File)
Sep 2 2025, 6:23 PM
Subscribers

Details

Summary

Enable sequence number offload.

This should both enable the sequence number offloading and disable
the net80211 TX lock from being acquired/released/checked.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64652
Build 61536: arc lint + arc unit

Event Timeline

bz requested changes to this revision.Aug 19 2025, 7:32 PM
bz added a subscriber: bz.
bz added inline comments.
sys/dev/rtwn/rtl8192c/r92c_tx.c
458

See comment for r12a_tx.c

sys/dev/rtwn/rtl8812a/r12a_tx.c
439

why is this one not having the % IEEE80211_SEQ_RANGE ?
I think it really wants to use ieee80211_tx_seqno_fetch_incr()

This revision now requires changes to proceed.Aug 19 2025, 7:32 PM
sys/dev/rtwn/rtl8812a/r12a_tx.c
439

I'll experiment with that later. I need to do some more experiments with rtwn with and without firmware - eg i think with firmware its handling stuff like NULL QoS frames and doing power save stuff in general, but without firmware we'd have to do it in net80211.

I cleaned up the seqno assignment stuff in D52301 and D52302. In particular after D52302, we can sweep the drivers and remove the "% IEEE80211_SEQ_RANGE" because, well, it's now done in the macro.

I've tested these with the suggested changes / questions and it works fine, so I'll clean up the diffs tonight and land em. Thanks bz!

👍 Still think you want to squash this one into D52301 or reduce this to the simple "enable offload" as the other functional changes are cleaned up already in D52301

Abandoning, but it landed!