Page MenuHomeFreeBSD

[rtwn] Migrate to use ieee80211_output_seqno_assign()
ClosedPublic

Authored by adrian on Aug 31 2025, 3:09 AM.
Referenced Files
Unknown Object (File)
Sat, Oct 11, 10:17 PM
Unknown Object (File)
Fri, Oct 10, 11:16 PM
Unknown Object (File)
Fri, Oct 10, 11:16 PM
Unknown Object (File)
Fri, Oct 10, 11:16 PM
Unknown Object (File)
Fri, Oct 10, 11:16 PM
Unknown Object (File)
Fri, Oct 10, 4:59 PM
Unknown Object (File)
Wed, Oct 8, 8:57 PM
Unknown Object (File)
Mon, Oct 6, 3:39 AM
Subscribers

Details

Summary

This is currently a straight substitution.

The sequence number code can likely be cleaned up to just always assign
it in the transmit path in the new world order, including some extra
flags to determine whether the frame belongs in an A-MPDU or not.

Locally tested:

  • RTL8812AU, STA mode

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested changes to this revision.Sep 1 2025, 1:11 AM
bz added a subscriber: bz.

Change order of commits. And squash the updated this one into D50693?

sys/dev/rtwn/rtl8192c/r92c_tx.c
458

So what's the point of adding the % here if in the next change the macro does it? You'll have to undo the % again then?

sys/dev/rtwn/rtl8812a/r12a_tx.c
438

dito

This revision now requires changes to proceed.Sep 1 2025, 1:11 AM

remove the % operator in the driver now that the net80211 macros do it for us

Yeah I was /just/ thinking about squishing them together into one commit.

Do I do that and just have two Differential Revision lines in the commit message?

Yeah I was /just/ thinking about squishing them together into one commit.

Do I do that and just have two Differential Revision lines in the commit message?

I'd be fine with that. If the magic works of auto-closing I have no idea. phabric-admins might know.

Or you get this in and then rebase the other one to just the one "enable ...". line setting FEXT?

This revision was not accepted when it landed; it landed in state Needs Review.Sep 6 2025, 6:25 AM
This revision was automatically updated to reflect the committed changes.