mwl: migrate to new net80211 encryption key API
Needs ReviewPublic
Actions

Authored by adrian on Sun, Jan 4, 3:44 AM.

Tags

None

Referenced Files

	F141771026: D54484.diff
	Sat, Jan 10, 4:30 AM

	F141765715: D54484.diff
	Sat, Jan 10, 2:45 AM

	Unknown Object (File)
	Mon, Jan 5, 1:40 PM

	Unknown Object (File)
	Mon, Jan 5, 10:22 AM

	Unknown Object (File)
	Mon, Jan 5, 10:10 AM

	Unknown Object (File)
	Mon, Jan 5, 2:42 AM

	Unknown Object (File)
	Sun, Jan 4, 11:05 PM

	Unknown Object (File)
	Sun, Jan 4, 6:54 PM

Subscribers

imp

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

Migrate to the new encryption key API rather than poking at the
key struct directly.

Notably this driver was very clear about its expectation the net80211
key layout w/ key, TX MIC and RX MIC matches the firmware layout
and just memcpy()'ed it. That has been refactored.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69602
Build 66485: arc lint + arc unit

Event Timeline

adrian created this revision.Sun, Jan 4, 3:44 AM

Herald added a subscriber: imp. · View Herald TranscriptSun, Jan 4, 3:44 AM

adrian requested review of this revision.Sun, Jan 4, 3:44 AM

Harbormaster completed remote builds in B69602: Diff 168987.Sun, Jan 4, 3:44 AM

adrian added a parent revision: D54483: rsu: migrate to new net80211 encryption key API.Sun, Jan 4, 3:47 AM

adrian added a child revision: D54485: LinuxKPI: migrate key data access to functions.

adrian added inline comments.Sun, Jan 4, 3:55 AM

sys/dev/mwl/if_mwl.c
1657	TODO: technically this should be tx/rx mic len calls, but I bet the firmware doesn't support anything other than 8+8 bytes here. (much like I bet everything else.)
1664	TODO: yup, another instance of IEEE80211_KEYBUF_SIZE being used where it really means "128 bit wep/tkip/ccmp key size". I'm going to need to clean this up too.

Revision Contents
Changeset List

Path

Size

sys/

dev/

mwl/

if_mwl.c

26 lines

Diff 168987

View Options

mwl: migrate to new net80211 encryption key APINeeds ReviewPublicActions