Differential D57799

net80211: fix CCMP/GCMP AAD for MFP frames
ClosedPublic
Actions

Authored by adrian on Wed, Jun 24, 4:18 AM.

Tags

Referenced Files

	Unknown Object (File)
	Wed, Jul 8, 10:30 AM

	Unknown Object (File)
	Tue, Jul 7, 7:47 PM

	Unknown Object (File)
	Tue, Jul 7, 5:28 AM

	Unknown Object (File)
	Mon, Jul 6, 12:18 AM

	Unknown Object (File)
	Fri, Jul 3, 6:09 AM

	Unknown Object (File)
	Thu, Jul 2, 8:48 AM

	Unknown Object (File)
	Thu, Jul 2, 8:48 AM

	Unknown Object (File)
	Thu, Jul 2, 8:48 AM

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rGa2d087b67e14: net80211: fix CCMP/GCMP AAD for MFP frames

Summary

Update ieee80211_crypto_init_aad() to do what 802.11-2020 says -
only mask fc[0] bits 4-6 on data frames, not on management frames.
This (with other diffs to actually negotiate MFP and configure
ath(4) for MFP + software keys) allows the CCMP path to decrypt
CCMP MFP frames in the software path.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Wed, Jun 24, 4:18 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptWed, Jun 24, 4:18 AM

adrian requested review of this revision.Wed, Jun 24, 4:18 AM

Harbormaster completed remote builds in B74181: Diff 180496.Wed, Jun 24, 4:18 AM

adrian added a parent revision: D57798: net80211: encrypt/decrypt MFP CCMP frames.Wed, Jun 24, 4:24 AM

adrian added a reviewer: wireless.

adrian added a project: wireless.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jul 1, 12:21 AM

Closed by commit rGa2d087b67e14: net80211: fix CCMP/GCMP AAD for MFP frames (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGa2d087b67e14: net80211: fix CCMP/GCMP AAD for MFP frames.

adrian added a child revision: D58098: net80211: update drivers to allocate sequence numbers in the raw path.Wed, Jul 8, 5:56 AM

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_crypto.c

9 lines

Diff 181132

sys/net80211/ieee80211_crypto.c

Loading...