Differential D50787

net80211: fix VHT node setup in hostap mode
ClosedPublic
Actions

Authored by adrian on Jun 11 2025, 5:06 AM.

Tags

Referenced Files

	Unknown Object (File)
	Tue, Aug 25, 8:21 AM

	Unknown Object (File)
	Sat, Aug 15, 4:58 AM

	Unknown Object (File)
	Fri, Aug 14, 4:51 PM

	Unknown Object (File)
	Thu, Aug 13, 2:36 PM

	Unknown Object (File)
	Thu, Aug 13, 12:43 PM

	Unknown Object (File)
	Wed, Aug 12, 11:19 AM

	Unknown Object (File)
	Sat, Aug 8, 4:05 PM

	Unknown Object (File)
	Fri, Aug 7, 6:41 PM

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rG4e78b9b5afe9: net80211: fix VHT node setup in hostap mode

Summary

Way back in 2017 I wrote the initial VHT hostap support, and then
added a NULL check here to stop it from panicing. However, there
is no VHTINFO IE in an ASSOC_REQ management frame. Thus, the node
would never have VHT state initialised.

This mirrors what HT node setup does (which again doesn't have
HTINFO IE's in an ASSOC_REQ frame), the upgrade will happen once
the exchange completes.

Fixes: 2023566223a4020d832bd4e25dc7dadfd660b836

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Jun 11 2025, 5:06 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJun 11 2025, 5:06 AM

adrian requested review of this revision.Jun 11 2025, 5:06 AM

Harbormaster completed remote builds in B64756: Diff 156809.Jun 11 2025, 5:06 AM

adrian added a parent revision: D50772: net80211: convert the rest of the native net80211 drivers to SEQNO_OFFLOAD.Jun 11 2025, 5:07 AM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian added a child revision: D50794: net80211: don't dereference a NULL HTINFO IE if it's presented.Jun 11 2025, 6:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 16 2025, 3:22 PM

Closed by commit rG4e78b9b5afe9: net80211: fix VHT node setup in hostap mode (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG4e78b9b5afe9: net80211: fix VHT node setup in hostap mode.

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_hostap.c

7 lines

ieee80211_vht.h

3 lines

ieee80211_vht.c

4 lines

Diff 158612

sys/net80211/ieee80211_hostap.c

Loading...

sys/net80211/ieee80211_vht.h

Loading...

sys/net80211/ieee80211_vht.c

Loading...