Page MenuHomeFreeBSD

iwx: tag RX frames as A_MPDU RX; tag A-MSDU frames appropriately
Needs ReviewPublic

Authored by adrian on Sun, Nov 16, 4:30 AM.
Referenced Files
F136692473: D53781.diff
Tue, Nov 18, 10:17 PM
Unknown Object (File)
Tue, Nov 18, 1:05 AM
Unknown Object (File)
Sun, Nov 16, 5:42 PM
Unknown Object (File)
Sun, Nov 16, 4:38 PM
Unknown Object (File)
Sun, Nov 16, 4:38 PM
Unknown Object (File)
Sun, Nov 16, 4:38 PM
Unknown Object (File)
Sun, Nov 16, 2:36 PM
Unknown Object (File)
Sun, Nov 16, 11:53 AM
Subscribers

Details

Reviewers
None
Group Reviewers
wireless
Summary
  • tag packets for 11n/11ac associated nodes with A_MPDU so they get passed into the reordering logic
  • tag A-MSDU frames with AMSDU and AMSDU_MORE so they don't get dropped due to duplicate sequence numbers.

Note: I haven't yet elicited A-MSDU in A-MPDU to fully test this,
but I do see the net80211 reordering logic kick in (which you can
see via wlanstats -i wlan0 -o ampdu 1); so although maybe on
some firmware / hardware versions we're supposed to get fully
in-sequence RX, at least on my AX210 I'm not.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68676
Build 65559: arc lint + arc unit

Event Timeline

Are you sure you are not getting full reassembled (re-aggregated) frames on your AX210 that better sees no sequence number checks in net80211 anymore?

Just dropping a note that this leads to ~10x throughput to pkg.f.o on my laptop -- previously averaging somewhere around ~2-3mbit/s due to constant out-of-order acks, up to ~25-30 mbit/s on average