Differential D54483

rsu: migrate to new net80211 encryption key API
ClosedPublic
Actions

Authored by adrian on Jan 4 2026, 3:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Feb 19, 11:34 PM

	Unknown Object (File)
	Sun, Feb 15, 3:14 AM

	Unknown Object (File)
	Jan 19 2026, 5:05 PM

	Unknown Object (File)
	Jan 18 2026, 7:05 PM

	Unknown Object (File)
	Jan 10 2026, 4:32 AM

	Unknown Object (File)
	Jan 8 2026, 8:34 PM

	Unknown Object (File)
	Jan 5 2026, 7:45 PM

	Unknown Object (File)
	Jan 5 2026, 11:06 AM

View All 13 Files

Subscribers

Details

Reviewers: None
Commits: rG6a6152bc292f: rsu: migrate to new net80211 encryption key API

Summary

Migrate to the new encryption key API rather than poking at the
key struct directly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Jan 4 2026, 3:44 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 4 2026, 3:44 AM

adrian requested review of this revision.Jan 4 2026, 3:44 AM

Harbormaster completed remote builds in B69601: Diff 168986.Jan 4 2026, 3:44 AM

adrian added a parent revision: D54482: wpi: migrate to new net80211 encryption key API.Jan 4 2026, 3:46 AM

adrian added a child revision: D54484: mwl: migrate to new net80211 encryption key API.

adrian added inline comments.Jan 4 2026, 3:53 AM

sys/dev/usb/wlan/if_rsu.c
1736–1737	This looks suspiciously like it's copying the TKIP key but it isn't; key.key is IEEE80211_KEYBUF_SIZE - 128 bits / 16 bytes. TKIP MIC is done in software. In any case I really should double/triple check if_rsu in TKIP mode before landing. (And I really need to figure out decoupling IEEE80211_KEYBUF_SIZE from everything because right now it assumes 128 bit keys and that's snaked its way through drivers and the WEP code (eg for rc4key[]) which means I can't change it :(

This revision was not accepted when it landed; it landed in state Needs Review.Sun, Feb 22, 3:30 AM

Closed by commit rG6a6152bc292f: rsu: migrate to new net80211 encryption key API (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG6a6152bc292f: rsu: migrate to new net80211 encryption key API.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

wlan/

19 lines

Diff 172415

sys/dev/usb/wlan/if_rsu.c

Loading...