rsu: migrate to new net80211 encryption key API
Needs ReviewPublic
Actions

Authored by adrian on Sun, Jan 4, 3:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 10, 4:32 AM

	Unknown Object (File)
	Thu, Jan 8, 8:34 PM

	Unknown Object (File)
	Mon, Jan 5, 7:45 PM

	Unknown Object (File)
	Mon, Jan 5, 11:06 AM

	Unknown Object (File)
	Mon, Jan 5, 10:02 AM

	Unknown Object (File)
	Mon, Jan 5, 4:20 AM

	Unknown Object (File)
	Mon, Jan 5, 2:30 AM

	Unknown Object (File)
	Sun, Jan 4, 11:24 PM

View All 9 Files

Subscribers

imp

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

Migrate to the new encryption key API rather than poking at the
key struct directly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69601
Build 66484: arc lint + arc unit

Event Timeline

adrian created this revision.Sun, Jan 4, 3:44 AM

Herald added a subscriber: imp. · View Herald TranscriptSun, Jan 4, 3:44 AM

adrian requested review of this revision.Sun, Jan 4, 3:44 AM

Harbormaster completed remote builds in B69601: Diff 168986.Sun, Jan 4, 3:44 AM

adrian added a parent revision: D54482: wpi: migrate to new net80211 encryption key API.Sun, Jan 4, 3:46 AM

adrian added a child revision: D54484: mwl: migrate to new net80211 encryption key API.

adrian added inline comments.Sun, Jan 4, 3:53 AM

sys/dev/usb/wlan/if_rsu.c
1736	This looks suspiciously like it's copying the TKIP key but it isn't; key.key is IEEE80211_KEYBUF_SIZE - 128 bits / 16 bytes. TKIP MIC is done in software. In any case I really should double/triple check if_rsu in TKIP mode before landing. (And I really need to figure out decoupling IEEE80211_KEYBUF_SIZE from everything because right now it assumes 128 bit keys and that's snaked its way through drivers and the WEP code (eg for rc4key[]) which means I can't change it :(

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

wlan/

if_rsu.c

19 lines

Diff 168986

View Options

rsu: migrate to new net80211 encryption key APINeeds ReviewPublicActions