Differential D54390

net80211: clean up time comparison in HT code
ClosedPublic
Actions

Authored by adrian on Dec 29 2025, 4:58 AM.

Details

Reviewers

None

Group Reviewers

wireless

Commits

rG7a5288a023ba: net80211: clean up time comparison in HT code

Summary

There's at least one place where the time comparison is wrong, leading
to some bad beahaviour around deciding to try and establish/reestablish
AMPDU TX sessions.

Start addressing these!

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Dec 29 2025, 4:58 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptDec 29 2025, 4:58 AM

adrian requested review of this revision.Dec 29 2025, 4:58 AM

Harbormaster completed remote builds in B69496: Diff 168686.Dec 29 2025, 4:58 AM

adrian added a parent revision: D53781: iwx: tag RX frames as A_MPDU RX; tag A-MSDU frames appropriately.Dec 29 2025, 4:58 AM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian added a child revision: D54462: run: rum: migrate to new net80211 encryption key API.Jan 2 2026, 11:41 PM

I don't get the correlation between your commit message and these changes. Is there an actual change (due to casting) in this change? Or is there a problem "somewhere" but this change does not necessarily address that?

yeah, without it the ampdu retry stuff eventually stops retrying until the counter loops around again for the comparison to work

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Feb 11, 6:05 AM

Closed by commit rG7a5288a023ba: net80211: clean up time comparison in HT code (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG7a5288a023ba: net80211: clean up time comparison in HT code.