net80211: clean up time comparison in HT code
Needs ReviewPublic
Actions

Authored by adrian on Mon, Dec 29, 4:58 AM.

Details

Reviewers

None

Group Reviewers

Summary

There's at least one place where the time comparison is wrong, leading
to some bad beahaviour around deciding to try and establish/reestablish
AMPDU TX sessions.

Start addressing these!

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69496
Build 66379: arc lint + arc unit

Event Timeline

adrian created this revision.Mon, Dec 29, 4:58 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptMon, Dec 29, 4:58 AM

adrian requested review of this revision.Mon, Dec 29, 4:58 AM

Harbormaster completed remote builds in B69496: Diff 168686.Mon, Dec 29, 4:58 AM

adrian added a parent revision: D53781: iwx: tag RX frames as A_MPDU RX; tag A-MSDU frames appropriately.Mon, Dec 29, 4:58 AM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian added a child revision: D54462: run: rum: migrate to new net80211 encryption key API.Fri, Jan 2, 11:41 PM

I don't get the correlation between your commit message and these changes. Is there an actual change (due to casting) in this change? Or is there a problem "somewhere" but this change does not necessarily address that?

yeah, without it the ampdu retry stuff eventually stops retrying until the counter loops around again for the comparison to work

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_ht.c

8 lines

Diff 168686

View Options

sys/net80211/ieee80211_ht.c

net80211: clean up time comparison in HT codeNeeds ReviewPublicActions