Page MenuHomeFreeBSD

[iwn] Don't originate NULL data frames in net80211
ClosedPublic

Authored by adrian on Aug 31 2025, 3:08 AM.
Referenced Files
F132012315: D52299.id.diff
Sun, Oct 12, 10:49 PM
Unknown Object (File)
Sun, Oct 12, 11:22 AM
Unknown Object (File)
Sun, Oct 12, 11:22 AM
Unknown Object (File)
Sun, Oct 12, 11:22 AM
Unknown Object (File)
Sun, Oct 12, 12:28 AM
Unknown Object (File)
Mon, Oct 6, 4:38 AM
Unknown Object (File)
Fri, Sep 26, 7:11 AM
Unknown Object (File)
Sep 8 2025, 6:37 PM
Subscribers

Details

Summary

Don't originate null data frames in net80211; leave that up to the
iwn firmware.

This should fix a bunch of cases where we're seeing out of sequence
802.11n aggregation data packets because net80211 power management
stuff was triggering NULL data frames when we don't need them and
messing up the firmware / ring buffer sequence number space.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Based on your description it sounds more like you want to disable PS in net80211 and leave it to iwn?

In D52299#1194452, @bz wrote:

Based on your description it sounds more like you want to disable PS in net80211 and leave it to iwn?

(I thought I replied to this?)

It needs power saving configuration and queuing isn't a problem, but the firmware will implement the final gatekeeping as needed. net80211 can implement the buffering to the NIC if harsher PS is required.

In any case, the main source of the null frames is association/reassociating stuff and some scan start/stop stuff.

(And yeah, iwn should also be converted to full offloaded scan, now that I know how it works..)

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Sep 20, 12:48 AM
This revision was automatically updated to reflect the committed changes.