Differential D53704

mtw: convert to new net80211 crypto key API
ClosedPublic
Actions

Authored by adrian on Nov 12 2025, 2:59 AM.

Tags

Referenced Files

	Unknown Object (File)
	Sun, May 17, 11:42 AM

	Unknown Object (File)
	Fri, May 15, 7:44 AM

	Unknown Object (File)
	Wed, May 13, 12:58 AM

	Unknown Object (File)
	Mon, May 11, 11:02 AM

	Unknown Object (File)
	Mon, May 11, 11:02 AM

	Unknown Object (File)
	Mon, May 11, 5:32 AM

	Unknown Object (File)
	Mon, May 11, 1:04 AM

	Unknown Object (File)
	Sun, May 10, 4:10 PM

View All 50 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG5431dafdb965: mtw: convert to new net80211 crypto key API

Summary

constify mtw_write_region_1()'s data field
convert to use ieee80211_crypto_get_*()
.. note that rx/tx mic data routines are explicitly being called, as this NIC is doing TKIP + MIC offload

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Nov 12 2025, 2:59 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 12 2025, 2:59 AM

adrian requested review of this revision.Nov 12 2025, 2:59 AM

Harbormaster completed remote builds in B68563: Diff 166272.Nov 12 2025, 2:59 AM

adrian added a parent revision: D52712: rtwn: migrate to new ieee80211 key data accessors.Nov 12 2025, 3:01 AM

adrian added a child revision: D53703: iwx: clean up debugging around key add/set; comments on delete.

adrian added a reviewer: wireless.Nov 13 2025, 4:38 AM

adrian added a project: wireless.

Seems fine ..

sys/dev/usb/wlan/if_mtw.c
1291	This at first seems rather bogus to const the argument which is then only DECONST. It seems there should be a better usbd wrapper for write which deals with a const buffer... The little I like this the much I see what it solves for you...

This revision is now accepted and ready to land.Nov 13 2025, 10:40 PM

Closed by commit rG5431dafdb965: mtw: convert to new net80211 crypto key API (authored by adrian). · Explain WhyNov 14 2025, 2:26 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG5431dafdb965: mtw: convert to new net80211 crypto key API.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

wlan/

24 lines

Diff 166406

sys/dev/usb/wlan/if_mtw.c

Loading...