Page MenuHomeFreeBSD

run: rum: migrate to new net80211 encryption key API
Needs ReviewPublic

Authored by adrian on Fri, Jan 2, 11:40 PM.
Referenced Files
Unknown Object (File)
Fri, Jan 9, 10:29 AM
Unknown Object (File)
Wed, Jan 7, 4:54 AM
Unknown Object (File)
Wed, Jan 7, 4:26 AM
Unknown Object (File)
Wed, Jan 7, 3:33 AM
Unknown Object (File)
Tue, Jan 6, 1:34 PM
Unknown Object (File)
Tue, Jan 6, 1:01 AM
Unknown Object (File)
Mon, Jan 5, 9:24 AM
Unknown Object (File)
Sun, Jan 4, 11:05 PM
Subscribers

Details

Reviewers
None
Group Reviewers
wireless
Summary

Migrate to the new encryption key API rather than poking at the
key struct directly.

Locally tested:

  • STA mode - run0: MAC/BBP RT2860 (rev 0x0101), RF RT2820 (MIMO 2T2R), address 00:0e:2e:e5:ae:3a

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69575
Build 66458: arc lint + arc unit

Event Timeline

bz added inline comments.
sys/dev/usb/wlan/if_run.c
2378

We really should just remove these and no longer allow them.
I think what I am trying to say is: remove that TODO comment.

sys/dev/usb/wlan/if_run.c
2378

you mean no longer allow WEP?

I still occasionally use WEP because I want to build a private network for old devices. It's still there.

sys/dev/usb/wlan/if_run.c
2378

You are worse than TKIP users ;-) We still do support OPEN for that :)

Well, does it really make sense to touch all the "legacy" drivers and change a check into a bool inline function, just because?

WEP needs to die die die or at least start hiding behind extra pain not introduce more work for no good?