Differential D52655

iwx: add some lock assertions in the TX start path
ClosedPublic
Actions

Authored by adrian on Sun, Sep 21, 4:56 AM.

Details

Reviewers

thj

Group Reviewers

wireless

Commits

rG262172de955f: iwx: add some lock assertions in the TX start path

Summary

The locking paths into these routines LOOK correct, but I figured
it'd be good to at least enforce we're not doing concurrent entry
into iwx_start() / iwx_tx() without the lock held.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Sun, Sep 21, 4:56 AM

Herald added a subscriber: imp. · View Herald TranscriptSun, Sep 21, 4:56 AM

adrian requested review of this revision.Sun, Sep 21, 4:56 AM

Harbormaster completed remote builds in B67219: Diff 162511.Sun, Sep 21, 4:56 AM

adrian added a parent revision: D52652: iwx: re-add sequence numbers for non-AMPDU, preserving previous behaviour.Sun, Sep 21, 4:57 AM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian added a child revision: D52664: iwm: assign sequence numbers even if we ask the firmware to override.Sun, Sep 21, 5:23 PM

right after the start of stab week seems like a good time to see if iwx explodes with these

This revision is now accepted and ready to land.Mon, Sep 22, 7:54 AM

Closed by commit rG262172de955f: iwx: add some lock assertions in the TX start path (authored by adrian). · Explain WhySat, Oct 4, 3:02 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG262172de955f: iwx: add some lock assertions in the TX start path.

Revision Contents
Changeset List

Path

Size

sys/

dev/

iwx/

if_iwx.c

6 lines

Diff 163513

View Options

iwx: add some lock assertions in the TX start pathClosedPublicActions